Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use SeedGenerator backend when creating variable #439

Merged
merged 1 commit into from
Jul 11, 2023
Merged

Use SeedGenerator backend when creating variable #439

merged 1 commit into from
Jul 11, 2023

Conversation

sampathweb
Copy link
Collaborator

Fixes #432 for RandomBrightness and RandomContrast preprocessing layer test failures on tf_data compatibility.

  • Use SeedGenerator backend when converting increment value to tensor
  • TFDataLayer should compare backend with environment backend when deciding to create seed specific to custom backend arg.

@sampathweb sampathweb requested a review from fchollet July 11, 2023 00:50
fchollet
fchollet approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fchollet fchollet merged commit f990033 into main Jul 11, 2023
5 checks passed
@haifeng-jin haifeng-jin deleted the fix-tf-data-seed-gen branch July 11, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fchollet fchollet fchollet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Torch GPU test failures
2 participants
@sampathweb @fchollet