Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add models to __init__ #442

Closed
wants to merge 4 commits into from
Closed

Add models to __init__ #442

wants to merge 4 commits into from

Conversation

IMvision12
Copy link

Added models to __init__ file

@fchollet

Copy link
Member

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. LGTM

@IMvision12
Copy link
Author

@fchollet I am not sure why Jax test is not executing : Error: The operation was canceled.

@fchollet
Copy link
Member

On second thought, this change should not be necessary. The public namespace is programmatically generated, so __init__ files are only useful for imports we do inside the codebase or in unit tests. And in this case, we're not importing any of these symbols from this location.

@fchollet fchollet closed this Jul 12, 2023
@IMvision12 IMvision12 deleted the __init__ branch July 12, 2023 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants