Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mosaic Augmentation for Object Detection #21

Closed
innat opened this issue Dec 10, 2021 · 7 comments
Closed

Mosaic Augmentation for Object Detection #21

innat opened this issue Dec 10, 2021 · 7 comments

Comments

@innat
Copy link
Contributor

innat commented Dec 10, 2021

Mosaic Augmentation

What is it?
The idea is to take 4 random samples and create a single sample of mosaic fashion with them. For example:

mosaic

Starter

@bhack
Copy link
Contributor

bhack commented Dec 10, 2021

@innat
Copy link
Contributor Author

innat commented Dec 10, 2021

Oh, I see. Does it mean that we should use these from the tensorflow/models garden or all those relevant operations will be moved here to strengthen the high-level api? Also why the mosaic.py file is under /yolo/ops/ directory? Shouldn't it be more general for all object detection models?

@bhack
Copy link
Contributor

bhack commented Dec 10, 2021

This is the old long story about where to collect reusable CV components.
I suppose that we could port these from the model garden to keras-cv.

@LukeWood LukeWood self-assigned this Dec 13, 2021
@LukeWood
Copy link
Contributor

LukeWood commented Dec 14, 2021

Think this looks like another good preprocessing layer.

I suppose that we could port these from the model garden to keras-cv.

yeah I agree, it's beginning to look like we are probably going to have a lot of code duplication between keras-cv and model garden. In my opinion this is to be expected - We do not want keras-cv to depend on model garden, but some of the functionality is the same.

@bhack thank you for continuing to point out the existing model garden implementations. They're extremely helpful to me.

@innat
Copy link
Contributor Author

innat commented Feb 9, 2022

@bhack @LukeWood @qlzh727
What should be the default target format (BoxMode) for object detection tasks? Will it be pascal format or coco format? In the object detection preprocessing layer, is it expected that the layer should support both formats as input?

@innat
Copy link
Contributor Author

innat commented Feb 15, 2022

@LukeWood could you please see the above query? I would most likely send a PR for mosaic if possible.

@LukeWood
Copy link
Contributor

Good question, probably corners? This can have its own issue to discuss. I'll re-open!

freedomtan pushed a commit to freedomtan/keras-cv that referenced this issue Jul 20, 2023
* fix keyword arguments for tf.cond

* rename arguments for cond function. Fix keyword argument for tf.cond
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants