Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded environment variable #1938

Merged
merged 1 commit into from
Jul 12, 2023
Merged

Conversation

jbischof
Copy link
Contributor

Setting KERAS_BACKEND should be enough to trigger Keras Core usage

@jbischof
Copy link
Contributor Author

/gcbrun

Copy link
Contributor

@ianstenbit ianstenbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

toxic_env 😭

@jbischof
Copy link
Contributor Author

jbischof commented Jul 12, 2023

Is there any way to check that the GCB tests ran as intended @ianstenbit? I can't see any print statements about the backend.

@ianstenbit
Copy link
Contributor

As-is on this branch, the GCB tests ran the normal test suite (just three times)

You can see one run result here: https://pantheon.corp.google.com/cloud-build/builds/dd860e52-ebe6-4b93-b794-96f1d70cd092;step=5?jsmode=o&project=keras-team-test

So this is all set.

@jbischof
Copy link
Contributor Author

Right, but do we need to check that the KERAS_BACKEND var was sufficient to trigger different backends instead of testing tf.keras over and over?

@ianstenbit
Copy link
Contributor

Right, but do we need to check that the KERAS_BACKEND var was sufficient to trigger different backends instead of testing tf.keras over and over?

Oh I see -- yes, right now this just triggered tf.keras over and over for the GCB tests (that's expected, because #1935 isn't done). For the non-GCB tests, we can tell that keras_core is being tested because some tests (e.g. the RCNN tests) are skipped on these CI runs, which is only true for Keras Core

@jbischof jbischof merged commit 5cb7d4d into keras-team:master Jul 12, 2023
9 checks passed
@jbischof jbischof deleted the toxic_env branch July 25, 2023 22:35
ghost pushed a commit to y-vectorfield/keras-cv that referenced this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants