Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

U-Net Research Paper Attached, Linter Issue Solved #1959

Merged
merged 10 commits into from
Jul 20, 2023
Merged

U-Net Research Paper Attached, Linter Issue Solved #1959

merged 10 commits into from
Jul 20, 2023

Conversation

NiharJani2002
Copy link
Contributor

@NiharJani2002 NiharJani2002 commented Jul 18, 2023

What does this PR do?

The original Research Paper of U-Net Is Attached, Along With That Linter Issue, Has Been Resolved.

Fixes # (issue)
Linter Issue Has Been Resolved. The Linter Showed Error Because The Docstring Was too long, so I kept the name of the research paper in one line, and research paper link in other line.

Before submitting

  • This PR fixes a typo or improves the docs
    Updates In Docstring of U-Net Research Paper

Who can review?

@ianstenbit

This Pull Request Is Successor of the PR #1954

NiharJani2002 and others added 6 commits July 15, 2023 18:11
…th code, added original research paper, followed the way keras-cv adds research paper along with code
The second line has been Deleted, As Per Your Suggestion.
Only Research Paper Is Now There In The Code
There is only one line between the research paper link and Args.
U-Net Research Paper In The Same Line, Along With It Linter Issue Is Resolved.
The Bitly Link Is Used.
U-Net Research Paper Attached Along With Original Research Paper of arxiv., Linter Issue Solved With The Help #noqa:E501
@NiharJani2002
Copy link
Contributor Author

NiharJani2002 commented Jul 19, 2023

Original Research Paper Attached With the help of #noqa:E501.
No Linter Error being there:

@ianstenbit
@ID6109

No Error

@@ -177,6 +177,8 @@ def UNet(
All function parameters require curried functions as inputs which return a
function that acts on tensors as inputs.

Reference:
- [U-Net: Convolutional Networks for Biomedical Image Segmentation](https://arxiv.org/abs/1505.04597) #noqa:E501
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The # noqa: E501 needs to be placed at the end of the doctring here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noqa: E501 attached at the end of the docstring,

noqa:E501 attached at the end of docstring

Copy link
Contributor

@jbischof jbischof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jbischof jbischof merged commit 7b50c93 into keras-team:master Jul 20, 2023
9 of 14 checks passed
ianstenbit added a commit to ianstenbit/keras-cv that referenced this pull request Jul 20, 2023
ghost pushed a commit to y-vectorfield/keras-cv that referenced this pull request Nov 16, 2023
* U-Net Code, did not have a original research paper, attached along with code, added original research paper, followed the way keras-cv adds research paper along with code

* Update keras_cv/models/__internal__/unet.py

The second line has been Deleted, As Per Your Suggestion.

* Update keras_cv/models/__internal__/unet.py

Only Research Paper Is Now There In The Code

* Update unet.py

There is only one line between the research paper link and Args.

* Linter Issue solved

* Update unet.py

U-Net Research Paper In The Same Line, Along With It Linter Issue Is Resolved.
The Bitly Link Is Used.

* arxiv. Paper Of U-Net Attached And with #noqa:E501

U-Net Research Paper Attached Along With Original Research Paper of arxiv., Linter Issue Solved With The Help #noqa:E501

* U-Net Paper attached, and # noqa: E501 at the end of docstring

# noqa: E501 placed at the end of Docstring
ghost pushed a commit to y-vectorfield/keras-cv that referenced this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants