[WiP] Switch Keras2 to tf_keras #2127
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fchollet
reviewed
Nov 6, 2023
There was a problem hiding this comment.
Thanks for the PR! We should also update the logic in keras_cv/backend/config.py to resolve the default "multi-backend" value.
IMO:
- Switch the name to something more explicit like "keras_3"
- Make it configurable by both the
.jsonand and env variable - To find the default value to use:
import keras, check if Keras 3. If so, use keras_3=True as default.- Else use Keras 2.
Also, we might want to drop keras_core support after the keras 3 release.
| import tf_keras as keras | ||
| except ImportError: | ||
| raise ImportError( | ||
| "Keras 2 requires the `tf_keras` package." |
| @@ -52,7 +52,13 @@ | |||
|
|
|||
| keras.backend.name_scope = keras.name_scope | |||
| else: | |||
| from tensorflow import keras | |||
| try: | |||
There was a problem hiding this comment.
We may want to be more conservative to enable people to use Keras 2 via tf.keras without having to install tf_keras:
from tensorflow import kerasif not hasattr(keras, "version"):thentf.kerasis Keras 2. We usekerasfrom TF.- else: try to import
tf_keras - if not available: raise
|
I think as discussed on chat, we can probably close this one in favor of #2132 |
|
Closing in favor of #2132 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches
from tensorflow import kerastoimport tf_keras as keraswhen usingkeras 2workflow.We currently use TensorFlow 2.13 in release (for Waymo?). If we can bump it to 2.14, we can switch to
tf_keras.https://github.com/keras-team/keras-cv/blob/master/.github/workflows/actions.yml#L36