Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[keras/layers/activation] Standardise docstring usage of "Default to" #17961

Conversation

SamuelMarks
Copy link
Contributor

This is one of many PRs. Discussion + request to split into multiple PRs @ #17748

…y,keras/layers/activation/softmax.py] Standardise docstring usage of "Default to"
@gbaned gbaned requested a review from qlzh727 April 13, 2023 05:51
@google-ml-butler google-ml-butler bot added the keras-team-review-pending Pending review by a Keras team member. label Apr 13, 2023
keras/layers/activation/relu.py Outdated Show resolved Hide resolved
@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Apr 20, 2023
@qlzh727
Copy link
Member

qlzh727 commented Apr 20, 2023

Please resolve the merge conflicit.

@gbaned gbaned removed ready to pull Ready to be merged into the codebase keras-team-review-pending Pending review by a Keras team member. kokoro:force-run labels Apr 21, 2023
# Conflicts:
#	keras/layers/activation/leaky_relu.py
#	keras/layers/activation/relu.py
#	keras/layers/activation/softmax.py
@SamuelMarks
Copy link
Contributor Author

@qlzh727 Resolved

@gbaned gbaned requested a review from qlzh727 April 24, 2023 04:41
@google-ml-butler google-ml-butler bot added the keras-team-review-pending Pending review by a Keras team member. label Apr 24, 2023
@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Apr 24, 2023
copybara-service bot pushed a commit that referenced this pull request Apr 25, 2023
…Default to"

Imported from GitHub PR #17961

This is one of many PRs. Discussion + request to split into multiple PRs @ #17748
Copybara import of the project:

--
d1b6b77 by Samuel Marks <807580+SamuelMarks@users.noreply.github.com>:

[keras/layers/activation/leaky_relu.py,keras/layers/activation/relu.py,keras/layers/activation/softmax.py] Standardise docstring usage of "Default to"

--
46449dc by Samuel Marks <807580+SamuelMarks@users.noreply.github.com>:

[keras/layers/activation/relu.py] Use backticks for defaults in docstrings

Merging this change closes #17961

FUTURE_COPYBARA_INTEGRATE_REVIEW=#17961 from SamuelMarks:keras.layers.activation-defaults-to d0ca2ee
PiperOrigin-RevId: 527017156
copybara-service bot pushed a commit that referenced this pull request Apr 25, 2023
…Default to"

Imported from GitHub PR #17961

This is one of many PRs. Discussion + request to split into multiple PRs @ #17748
Copybara import of the project:

--
d1b6b77 by Samuel Marks <807580+SamuelMarks@users.noreply.github.com>:

[keras/layers/activation/leaky_relu.py,keras/layers/activation/relu.py,keras/layers/activation/softmax.py] Standardise docstring usage of "Default to"

--
46449dc by Samuel Marks <807580+SamuelMarks@users.noreply.github.com>:

[keras/layers/activation/relu.py] Use backticks for defaults in docstrings

Merging this change closes #17961

FUTURE_COPYBARA_INTEGRATE_REVIEW=#17961 from SamuelMarks:keras.layers.activation-defaults-to d0ca2ee
PiperOrigin-RevId: 527017156
@mihirparadkar mihirparadkar removed the keras-team-review-pending Pending review by a Keras team member. label Apr 26, 2023
copybara-service bot pushed a commit that referenced this pull request Apr 26, 2023
…Default to"

Imported from GitHub PR #17961

This is one of many PRs. Discussion + request to split into multiple PRs @ #17748
Copybara import of the project:

--
d1b6b77 by Samuel Marks <807580+SamuelMarks@users.noreply.github.com>:

[keras/layers/activation/leaky_relu.py,keras/layers/activation/relu.py,keras/layers/activation/softmax.py] Standardise docstring usage of "Default to"

--
46449dc by Samuel Marks <807580+SamuelMarks@users.noreply.github.com>:

[keras/layers/activation/relu.py] Use backticks for defaults in docstrings

Merging this change closes #17961

FUTURE_COPYBARA_INTEGRATE_REVIEW=#17961 from SamuelMarks:keras.layers.activation-defaults-to d0ca2ee
PiperOrigin-RevId: 527017156
@copybara-service copybara-service bot merged commit 605b2d7 into keras-team:master Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to pull Ready to be merged into the codebase size:S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants