Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[keras/preprocessing] Standardise docstring usage of "Default to" #17977

Merged

Conversation

SamuelMarks
Copy link
Contributor

This is one of many PRs. Discussion + request to split into multiple PRs @ #17748

@gbaned gbaned requested a review from haifeng-jin April 13, 2023 05:57
@google-ml-butler google-ml-butler bot added the keras-team-review-pending Pending review by a Keras team member. label Apr 13, 2023
@haifeng-jin haifeng-jin removed the keras-team-review-pending Pending review by a Keras team member. label Apr 21, 2023
keras/preprocessing/text.py Outdated Show resolved Hide resolved
@gbaned gbaned requested a review from haifeng-jin May 4, 2023 08:16
@gbaned gbaned added the keras-team-review-pending Pending review by a Keras team member. label May 4, 2023
@divyashreepathihalli divyashreepathihalli removed the keras-team-review-pending Pending review by a Keras team member. label May 4, 2023
keras/preprocessing/image.py Outdated Show resolved Hide resolved
…directory` docstring ; `flow_from_directory` defaults-to in docstring
@gbaned gbaned requested a review from haifeng-jin May 5, 2023 07:57
@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels May 8, 2023
copybara-service bot pushed a commit that referenced this pull request May 16, 2023
…ult to"

Imported from GitHub PR #17977

This is one of many PRs. Discussion + request to split into multiple PRs @ #17748
Copybara import of the project:

--
d7486bf by Samuel Marks <807580+SamuelMarks@users.noreply.github.com>:

[keras/preprocessing/image.py,keras/preprocessing/text.py] Standardise docstring usage of "Default to"

--
af5d96a by Samuel Marks <807580+SamuelMarks@users.noreply.github.com>:

[keras/preprocessing/text.py] Docstring grammar improvements

--
44c0b83 by Samuel Marks <807580+SamuelMarks@users.noreply.github.com>:

[keras/preprocessing/image.py] Consistent indent of 2 for `flow_from_directory` docstring ; `flow_from_directory` defaults-to in docstring

Merging this change closes #17977

FUTURE_COPYBARA_INTEGRATE_REVIEW=#17977 from SamuelMarks:keras.preprocessing-defaults-to 44c0b83
PiperOrigin-RevId: 530503462
@copybara-service copybara-service bot merged commit 7c08a05 into keras-team:master May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to pull Ready to be merged into the codebase size:S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants