Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds scikit-learn dependency to setup #20644

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

sampathweb
Copy link
Collaborator

#20599 added dependency to sklearn, but was not included in pyproject.toml. This caused the nightly wheel to not include it and fails TensorFlow nightly build. This PR adds scikit-learn as a Keras Deps.

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Dec 13, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.52%. Comparing base (a237437) to head (060ea3f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #20644   +/-   ##
=======================================
  Coverage   82.52%   82.52%           
=======================================
  Files         529      529           
  Lines       49018    49018           
  Branches     7625     7625           
=======================================
  Hits        40454    40454           
  Misses       6727     6727           
  Partials     1837     1837           
Flag Coverage Δ
keras 82.36% <ø> (ø)
keras-jax 65.68% <ø> (ø)
keras-numpy 60.57% <ø> (-0.01%) ⬇️
keras-tensorflow 66.48% <ø> (ø)
keras-torch 65.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jeffcarp jeffcarp merged commit 7a16b8e into keras-team:master Dec 13, 2024
8 of 10 checks passed
@google-ml-butler google-ml-butler bot removed awaiting review ready to pull Ready to be merged into the codebase labels Dec 13, 2024
@sampathweb sampathweb deleted the fix-sklearn-deps branch December 13, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants