unsubscribe from mqtt subscriptions

kerberos-io · Feb 18, 2023 · 7671b1c · 7671b1c
1 parent 4cc8135
commit 7671b1c
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 2 deletions.
diff --git a/machinery/src/components/Config.go b/machinery/src/components/Config.go
@@ -56,6 +56,9 @@ func GetSnapshot() string {
 		content, _ := ioutil.ReadAll(reader)
 		// Encode as base64.
 		snapshot = base64.StdEncoding.EncodeToString(content)
+
+		// Close reader
+		reader = nil
 	}
 	return snapshot
 }
@@ -146,6 +149,9 @@ func OpenConfig(configuration *models.Configuration) {
 		conjungo.Merge(&s3, configuration.CustomConfig.S3, opts)
 		configuration.Config.S3 = &s3
 
+		// Cleanup
+		opts = nil
+
 	} else if os.Getenv("DEPLOYMENT") == "" || os.Getenv("DEPLOYMENT") == "agent" {
 
 		// Local deployment means we do a stand-alone installation

diff --git a/machinery/src/components/Kerberos.go b/machinery/src/components/Kerberos.go
@@ -222,7 +222,7 @@ func RunAgent(configuration *models.Configuration, communication *models.Communi
 		close(communication.HandleONVIF)
 		close(communication.HandleLiveHDHandshake)
 		close(communication.HandleMotion)
-		routers.DisconnectMQTT(mqttClient)
+		routers.DisconnectMQTT(mqttClient, &configuration.Config)
 
 		// Wait a few seconds to stop the decoder.
 		time.Sleep(time.Second * 3)

diff --git a/machinery/src/routers/mqtt/main.go b/machinery/src/routers/mqtt/main.go
@@ -193,8 +193,16 @@ func MQTTListenerHandleONVIF(mqttClient mqtt.Client, hubKey string, configuratio
 	})
 }
 
-func DisconnectMQTT(mqttClient mqtt.Client) {
+func DisconnectMQTT(mqttClient mqtt.Client, config *models.Config) {
 	if mqttClient != nil {
+		// Cleanup all subscriptions.
+		mqttClient.Unsubscribe("kerberos/" + config.HubKey + "/device/" + config.Key + "/request-live")
+		mqttClient.Unsubscribe(config.Key + "/register")
+		mqttClient.Unsubscribe("kerberos/webrtc/keepalivehub/" + config.Key)
+		mqttClient.Unsubscribe("kerberos/webrtc/peers/" + config.Key)
+		mqttClient.Unsubscribe("candidate/cloud")
+		mqttClient.Unsubscribe("kerberos/onvif/" + config.Key)
 		mqttClient.Disconnect(1000)
+		mqttClient = nil
 	}
 }