Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert to string + upgrade to 0.67.0 #10

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Conversation

cedricve
Copy link
Member

@cedricve cedricve commented Oct 30, 2024

Description

Motivation

The primary motivation for this pull request is to ensure that all values in the Helm chart are strings where required. This can help prevent potential issues with type mismatches in the configuration. Additionally, upgrading the chart version to 0.67.0 ensures that users are aware of this change and can benefit from any other improvements or fixes included in this new version.

Changes

  1. Version Upgrade:

    • Updated the chart version in charts/hub/Chart.yaml from 0.66.0 to 0.67.0.
  2. Configuration Update:

    • Converted the value of nginx.ingress.kubernetes.io/enable-cors in charts/hub/templates/kerberos-hub/hub-api.yaml from a boolean to a string (true to "true").

Benefits

  • Type Consistency: Ensures that all configurations comply with expected types, reducing the risk of runtime errors or misconfigurations.
  • Version Clarity: The version bump to 0.67.0 clearly communicates to users that there have been changes and they should update their deployments accordingly.

This pull request improves the overall stability and maintainability of the project by enforcing consistent data types and keeping the versioning clear and up-to-date.

@cedricve cedricve merged commit d72e7ae into main Oct 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant