Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to 0.58.0 #2

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Conversation

cedricve
Copy link
Member

@cedricve cedricve commented Oct 4, 2024

Pull Request: Upgrade to 0.58.0

Motivation

This pull request upgrades the chart version from 0.57.0 to 0.58.0 to incorporate recent updates and improvements. The primary motivation behind this upgrade is to ensure compatibility with the latest Kubernetes API versions and improve the overall maintainability and readability of the Helm templates.

Summary of Changes

  1. Version Bump:

    • Updated the chart version in charts/hub/Chart.yaml from 0.57.0 to 0.58.0.
  2. Template Improvements:

    • Added hyphens (-) to the conditionals in charts/hub/templates/kerberos-hub/hub-frontend.yaml to maintain proper indentation and formatting.
    • Ensured consistent handling of Kubernetes API versions for Ingress resources:
      • Used networking.k8s.io/v1 if available.
      • Fallback to networking.k8s.io/v1beta1 if v1 is not available.
    • Improved conditional indentation for better readability and maintainability.

Benefits

  • Compatibility: Ensures the Helm chart is compatible with the latest Kubernetes API versions, reducing the risk of deprecation issues in future Kubernetes releases.
  • Readability: Enhances the readability and maintainability of the Helm templates by using consistent indentation and formatting practices.
  • Future-proofing: Aligns with best practices for Helm template development, making future updates and maintenance easier.

By upgrading to version 0.58.0, we aim to keep the project up-to-date with the latest standards and improve the overall quality of the Helm charts.

@cedricve cedricve merged commit d23dd5f into main Oct 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant