Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Title: Enable OAuth on Hub API as well
Motivation and Context:
This pull request introduces OAuth2 proxy support to the Hub API and Hub Frontend Demo services. By enabling OAuth2 proxy, we enhance the security of our services by enforcing authentication and ensuring that only authorized users can access them.
Changes:
Chart Version Increment:
0.61.0
to0.62.0
incharts/hub/Chart.yaml
to reflect the new changes and maintain semantic versioning.Hub API Ingress Annotations:
charts/hub/templates/kerberos-hub/hub-api.yaml
.kerberoshub.oauth2Proxy.enabled
is set to true, the following annotations are added:nginx.ingress.kubernetes.io/auth-url
: Points to the OAuth2 authentication URL.nginx.ingress.kubernetes.io/auth-signin
: Redirects to the OAuth2 sign-in URL.Hub Frontend Demo Ingress Annotations:
charts/hub/templates/kerberos-hub/hub-frontend-demo.yaml
.Benefits:
By making these changes, we ensure that our services are more secure and aligned with best practices for authentication and authorization.