Refactor ProfileNetCDFWriter to include the dba to ngdac conversions #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Bobfrat Would it be a major pain to subclass ProfileNetCDFWriter to something like DbaProfileNetCDFWriter and just add this method? I really would like to keep the ProfileNetCDFWriter source-file-agnostic so that I/we don't have to keep adding methods to the class. Thoughts? |
|
yeah thats not a problem at all, I'll update this PR |
|
@kerfoot just made that update, can you have a look? |
kerfoot
requested changes
Aug 3, 2018
There was a problem hiding this comment.
- The ProfileNetCDFWriter class has a self._logger logger. Can you change all of the logging calls in the method to use the ProfileNetCDFWriter class logger?
- I've made some changes to the TrajectoryNetCDFWriter class for the navy work. Don't think there are conflicts but I'd like to push the changes before merging and test. Does that work for you?
|
@kerfoot sounds good on both comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kerfoot I'm going to be importing this package into the upload tools code rather than running it from the command line, so this refactor will make it easier to use by putting most of the heavy lifting from
dba_to_ngdac_profile_nc.pyinto theProfileNetCDFWriterclass.If you're ok with this, I can do the same with the other scripts:
dba_to_profile_nc.pyanddba_to_trajectory_nc.py