Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pyproject.toml with [build-system] section to be compliant with PEP-518 #14

Merged
merged 1 commit into from
Dec 28, 2023

Conversation

pacorofe
Copy link

I was trying to install the package using pdm package manager, but I was getting the error ModuleNotFoundError: No module named 'pybind11' even if I had done pdm add pybind11 before.

Reading further above in the trace-back I found this message:

pdm.exceptions.BuildError: Build backend raised error: Module 'pybind11' is missing, please make sure it is specified in
the 'build-system.requires' section. If it is not possible, add it to the project and use '--no-isolation' option.
Showing the last 10 lines of the build output:
    return self._get_build_requires(config_settings, requirements=['wheel'])

By adding the pyproject.toml as done in this PR of fastText I managed to solve the issue.

I can now install the package doing: pdm add "graph-walker @ git+https://github.com/pacorofe/graph-walker". So ideally this would be merged and a new version would be released.

Note that by adding this change one does not need to install pybind11 before installing the package.

@kerighan kerighan merged commit 8eb43a1 into kerighan:master Dec 28, 2023
@kerighan
Copy link
Owner

Done. Thanks for helping out.

@pacorofe
Copy link
Author

Thank you for building this useful tool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants