add pyproject.toml with [build-system] section to be compliant with PEP-518 #14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to install the package using pdm package manager, but I was getting the error
ModuleNotFoundError: No module named 'pybind11'
even if I had donepdm add pybind11
before.Reading further above in the trace-back I found this message:
By adding the pyproject.toml as done in this PR of fastText I managed to solve the issue.
I can now install the package doing:
pdm add "graph-walker @ git+https://github.com/pacorofe/graph-walker"
. So ideally this would be merged and a new version would be released.Note that by adding this change one does not need to install
pybind11
before installing the package.