-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle incompleted/missclassified tables and figures #1207
Open
lfoppiano
wants to merge
19
commits into
master
Choose a base branch
from
bugfix/fix-dropped-misclassified-text
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lfoppiano
changed the title
Handle malformed tables and figures
Handle incompleted/missclassified tables and figures
Dec 4, 2024
…re is likely more figures/tables obtained by the specific models as in contrast with the initial fulltext sequence
lfoppiano
force-pushed
the
bugfix/fix-dropped-misclassified-text
branch
from
December 19, 2024 15:16
941d472
to
f036e0a
Compare
lfoppiano
force-pushed
the
bugfix/fix-dropped-misclassified-text
branch
from
December 19, 2024 16:31
b0b5051
to
09c824d
Compare
lfoppiano
added
bug
From Hemiptera and especially its suborder Heteroptera
enhancement
labels
Dec 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix dropping on the floor some text that has been mis-classified as
<table>
or<figure>
by the fulltext model, but that is considered invalid at a second stage.The approach is to revert invalid table/figure to paragraph directly in the fulltext sequence, instead of removing them from the output.
PR #963 might solve the problem on the long term, however this PR address the short-term timeline.