Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle incompleted/missclassified tables and figures #1207

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

lfoppiano
Copy link
Collaborator

@lfoppiano lfoppiano commented Dec 4, 2024

This PR fix dropping on the floor some text that has been mis-classified as <table> or <figure> by the fulltext model, but that is considered invalid at a second stage.

The approach is to revert invalid table/figure to paragraph directly in the fulltext sequence, instead of removing them from the output.

PR #963 might solve the problem on the long term, however this PR address the short-term timeline.

@coveralls
Copy link

coveralls commented Dec 4, 2024

Coverage Status

coverage: 40.873% (+0.2%) from 40.718%
when pulling 09c824d on bugfix/fix-dropped-misclassified-text
into 09b28cd on master.

@lfoppiano lfoppiano changed the title Handle malformed tables and figures Handle incompleted/missclassified tables and figures Dec 4, 2024
@lfoppiano lfoppiano force-pushed the bugfix/fix-dropped-misclassified-text branch from 941d472 to f036e0a Compare December 19, 2024 15:16
@lfoppiano lfoppiano force-pushed the bugfix/fix-dropped-misclassified-text branch from b0b5051 to 09c824d Compare December 19, 2024 16:31
@lfoppiano lfoppiano marked this pull request as ready for review December 22, 2024 06:27
@lfoppiano lfoppiano requested a review from kermitt2 December 22, 2024 06:32
@lfoppiano lfoppiano added bug From Hemiptera and especially its suborder Heteroptera enhancement labels Dec 22, 2024
@lfoppiano lfoppiano added this to the 0.8.2 milestone Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug From Hemiptera and especially its suborder Heteroptera enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants