fix(docker/k8s): Fix image naming #2705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuclearcat
added
the
staging-skip
nuclearcat
force-pushed
the
fix-docker-naming
branch
from
3daf36e
to
1ac6cfc
Compare
nuclearcat
added a commit
to nuclearcat/kernelci-pipeline
that referenced
this pull request
Oct 11, 2024
This commit depends on PR kernelci/kernelci-core#2705 Signed-off-by: Denys Fedoryshchenko <denys.f@collabora.com>
nuclearcat
force-pushed
the
fix-docker-naming
branch
from
1ac6cfc
to
87c89fd
Compare
nuclearcat
force-pushed
the
fix-docker-naming
branch
from
87c89fd
to
1d46de9
Compare
We had previously hack with hardcoding ghcr.io. Now we make it more flexible, so people can set their own image url, and our staging instance automatically add staging- prefix in appropriate place. Signed-off-by: Denys Fedoryshchenko <denys.f@collabora.com>
nuclearcat
force-pushed
the
fix-docker-naming
branch
from
1d46de9
to
1e57458
Compare
nuclearcat
added a commit
to nuclearcat/kernelci-pipeline
that referenced
this pull request
Oct 15, 2024
This commit depends on PR kernelci/kernelci-core#2705 Signed-off-by: Denys Fedoryshchenko <denys.f@collabora.com>
We must be able to update image name Signed-off-by: Denys Fedoryshchenko <denys.f@collabora.com>
nuclearcat
added a commit
to nuclearcat/kernelci-pipeline
that referenced
this pull request
Oct 15, 2024
This commit depends on PR kernelci/kernelci-core#2705 Signed-off-by: Denys Fedoryshchenko <denys.f@collabora.com>
pawiecz
approved these changes
Oct 15, 2024
nuclearcat
removed
the
staging-skip
|
tested on staging |
github-merge-queue bot
pushed a commit
to kernelci/kernelci-pipeline
that referenced
this pull request
Oct 18, 2024
This commit depends on PR kernelci/kernelci-core#2705 Signed-off-by: Denys Fedoryshchenko <denys.f@collabora.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had previously hack with hardcoding ghcr.io.
Now we make it more flexible, so people can set their own image url, and our staging instance automatically add staging- prefix in appropriate place.