Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added scroll to the tree view #5651

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Conversation

Niravdas
Copy link
Contributor

  • Added scroll to the tree view
  • Made it responsive with media query
  • Modified scroll bar height to make it look attractive

Niravdas and others added 2 commits October 24, 2024 22:24
- Made it responsive with media query
- Modified scroll bar height to make it look attractive
@Niravdas
Copy link
Contributor Author

The small screen having scrollbar.

image

On larger screen removed scroll due to responsiveness.
Screenshot 2024-10-24 223429

@MilosPaunovic
Copy link
Member

I haven't seen @Skraye self-requested a review here, so I'll just leave this note I've already found and be happy to give it over for a final review and merging 😄

So, when there is a scrollbar, the highlight color of the selected line with the file/folder does not go all the way to the end. Could you see and amend that @Niravdas?
image

@Niravdas
Copy link
Contributor Author

Thanks for the feedback, I am looking into this.

@Niravdas
Copy link
Contributor Author

@MilosPaunovic ,
I am unable to re-produce issue with file name,
I tried it with dark theme and adding JS file too.

Is there any specific steps which can help me re-produce the issue?

image

image

@MilosPaunovic
Copy link
Member

Just click on the last file, to open it. It will change background color.

@Niravdas
Copy link
Contributor Author

@MilosPaunovic
Thanks for feedback, it is resolved now.

@Skraye Skraye requested review from MilosPaunovic and removed request for Skraye November 12, 2024 07:57
@Skraye
Copy link
Member

Skraye commented Nov 12, 2024

@MilosPaunovic has you have started, I'll let you finish this one (given that is also only frontend)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: To review
Development

Successfully merging this pull request may close these issues.

3 participants