Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop support for Python 3.6 with pyupgrade and other pre-commit tools #68

Merged
merged 9 commits into from
Feb 25, 2022
Merged

drop support for Python 3.6 with pyupgrade and other pre-commit tools #68

merged 9 commits into from
Feb 25, 2022

Conversation

graingert
Copy link
Collaborator

No description provided.

@graingert
Copy link
Collaborator Author

this also drops support for all EOL python versions (which happens to be all previously supported python versions)

@graingert
Copy link
Collaborator Author

might be worth a v2 for this change

hugovk
hugovk reviewed Feb 25, 2022
View reviewed changes
Copy link
Contributor

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

I suggest mentioning the EOL drop prominently in the PR title, for extra visibility.

.pre-commit-config.yaml Outdated Show resolved Hide resolved
.pre-commit-config.yaml Show resolved Hide resolved
@graingert graingert changed the title configure pre-commit drop support for Python 3.6 with pyupgrade and other pre-commit tools Feb 25, 2022
hugovk
hugovk approved these changes Feb 25, 2022
View reviewed changes
Copy link
Contributor

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@graingert graingert merged commit a28a7a3 into master Feb 25, 2022
@graingert graingert deleted the configure-pre-commit branch February 25, 2022 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugovk hugovk hugovk approved these changes

@kevin1024 kevin1024 Awaiting requested review from kevin1024

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@graingert @hugovk