Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tooltips less sticky #139

Merged
merged 3 commits into from
Nov 1, 2023
Merged

Make tooltips less sticky #139

merged 3 commits into from
Nov 1, 2023

Conversation

kevinddchen
Copy link
Owner

@kevinddchen kevinddchen commented Oct 31, 2023

Previously, the tooltip was "sticky" in the sense that when your cursor hovered over an establishment/landmark and the tooltip bubble was very big, you could move your cursor over the tooltip text itself and it would not disappear, even if the tooltip bubble was covering another establishment/landmark. This caused misclicks because clicking on the tooltip bubble registers the click to the establishment/landmark the tooltip belongs to, not the establishment/landmark underneath the tooltip.

This PR makes it so that hovering over a tooltip itself does nothing special. Now tooltips disappear when the cursor leaves the underlying establishment/landmark div, as expected.

This PR resolves #135. I am surprised this problem could be fixed with a single line!

@kevinddchen kevinddchen self-assigned this Oct 31, 2023
@kevinddchen kevinddchen changed the title Tooltip no longer hoverable Make tooltips less sticky Oct 31, 2023
@kevinddchen kevinddchen merged commit ee6fa33 into main Nov 1, 2023
1 check passed
@kevinddchen kevinddchen deleted the kchen/tooltip branch November 1, 2023 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not make tooltip clickable/hoverable
2 participants