New unicode escapes #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK, I've looked into the This rust-peg pull request, however, can be safely merged now, without waiting on an updated |
Glob imports require the user to use #[features(globs)], so let's not generate them if we don't need to.
Note that this only handles the input side, not the output side. Fixing the output side will require changes to libsyntax. Support for old style \u and \U escapes has been left in for now to ease the transition.
emk
force-pushed
the
new_unicode_escapes
branch
from
a2e9c1f to
02b609f
Compare
|
Thank you for the quick review! I've made the changes you suggested. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, and thank you for maintaining rust-peg!
Here are two patches to help update rust-peg for the latest version of Rust:
allow, and so the first patch updates the generated code accordingly.Unfortunately, there's one missing piece here:
libsyntax's pretty-printer still outputs old-style escape sequences. I'm going to look into that next, and see if it's easy to fix.