Skip to content

Commit

Permalink
add TODO for rules in recommended ESLint 9 config
Browse files Browse the repository at this point in the history
Once we upgrade to ESLint v9, the recommended config will enable several
rules by default.  There'll be no need to enable these explicitly.

eslint/eslint@6ee3e9e

Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
  • Loading branch information
kevinoid committed Jun 17, 2024
1 parent ce6bda9 commit 1fa6f84
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion rules/best-practices.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ module.exports = {
"curly": ["error", "all"],

// disallow empty static blocks
// TODO [eslint-config-airbnb-base@>=16]: Remove if enabled
// TODO [eslint@>=9]: Remove. Included in default config.
"no-empty-static-block": "error",

// disallow unnecessary parentheses
Expand Down
3 changes: 2 additions & 1 deletion rules/possible-errors.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
module.exports = {
"rules": {
// disallow expressions where the operation doesn't affect the value
// TODO [eslint-config-airbnb-base@>=16]: Remove if enabled
// TODO [eslint@>=9]: Remove. Included in default config.
"no-constant-binary-expression": "error",

// disallow constant expressions in conditions
Expand All @@ -23,6 +23,7 @@ module.exports = {
"no-new-native-nonconstructor": "error",

// disallow unused private class members
// TODO [eslint@>=9]: Remove. Included in default config.
"no-unused-private-class-members": "error"
}
};

0 comments on commit 1fa6f84

Please sign in to comment.