Skip to content

Commit

Permalink
disable regexp/require-unicode-sets-regexp
Browse files Browse the repository at this point in the history
As with regexp/require-unicode-regexp, the pain outweighs the gain of
enabling this rule at this point.  Disable it.

Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
  • Loading branch information
kevinoid committed Oct 17, 2023
1 parent 70dc3f3 commit dd511c0
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions rules/regexp.js
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,13 @@ module.exports = {
// ASCII-only case-insensitive patterns) that it is counter-productive.
"regexp/require-unicode-regexp": "off",

// Don't require v flag
// As with require-unicode-regexp, there are enough cases where v is not
// useful (e.g. literal patterns, ASCII-only case-insensitive patterns)
// that it is counter-productive.
// Additionally, it's only supported on Node.js 20 and later.
"regexp/require-unicode-sets-regexp": "off",

// Don't require elements of character classes to be sorted.
// Although this is nice in theory, in practice I find sorting ASCII
// punctuation before numbers and letters to be more difficult to read.
Expand Down

0 comments on commit dd511c0

Please sign in to comment.