Skip to content

Commit

Permalink
Remove --strict-peer-deps from npm install in CI
Browse files Browse the repository at this point in the history
Since it causes npm install to fail with ERESOLVE on npm@^7.20.3 or
npm@>=8.0.0 <8.1.1 due to the combination of eslint@^7.0.0 and
eslint-plugin-node@^11.0.0:
npm/cli#3868 (comment)

Rather than updating npm on the runner during each CI run, remove
--strict-peer-deps until a version of Node.js ships with npm@^8.1.1.

Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
  • Loading branch information
kevinoid committed Oct 27, 2021
1 parent b9d9852 commit bbeb777
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions .github/workflows/node.js.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,9 @@ jobs:
- name: Display Node.js version
run: node --version
- name: Install dependencies
run: npm install --strict-peer-deps
# Note: Not using --strict-peer-deps until npm@8.1.1 ships with Node.js
# due to https://github.com/npm/cli/issues/3868
run: npm install
- name: Lint
run: npm run lint
- name: Run tests
Expand Down Expand Up @@ -97,7 +99,9 @@ jobs:
- name: Display Node.js version
run: node --version
- name: Install dependencies
run: npm install --strict-peer-deps
# Note: Not using --strict-peer-deps until npm@8.1.1 ships with Node.js
# due to https://github.com/npm/cli/issues/3868
run: npm install
- name: Run tests
run: npm run test-unit-cov
# Note: Not uploading to Codecov, due to poor support for matrix builds
Expand Down

0 comments on commit bbeb777

Please sign in to comment.