Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade demo dependencies (react 18, react-scripts 5) #218

Merged
merged 7 commits into from
Jun 27, 2022
Merged

Upgrade demo dependencies (react 18, react-scripts 5) #218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4095082
demo: upgrade lodash and also parent lib version
kevinsqi Jun 27, 2022
6f8f616
demo: add @babel/helper-define-map to fix error when starting up demo…
kevinsqi Jun 27, 2022
c03a58c
demo: upgrade to react-scripts 3.4.4
kevinsqi Jun 27, 2022
67fb003
demo: run yarn upgrade, and add @babel/helper-regex to fix app startu…
kevinsqi Jun 27, 2022
cbe2bd6
demo: upgrade to react 18 and react-dom 18
kevinsqi Jun 27, 2022
bf5eb0e
demo: fix typing issue with react 18
kevinsqi Jun 27, 2022
99eaf9d
demo: upgrade to react-scripts 5.x
kevinsqi Jun 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions demo/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,17 +8,17 @@
"@types/d3-ease": "^1.0.8",
"@types/jest": "24.0.11",
"@types/node": "11.13.6",
"@types/react": "16.8.14",
"@types/react-dom": "16.8.4",
"@types/react": "^18.0.0",
"@types/react-dom": "^18.0.0",
"classnames": "^2.2.6",
"d3-ease": "^1.0.5",
"gh-pages": "^2.0.1",
"lodash": "^4.17.15",
"react": "^17.0.2",
"react": "^18.0.0",
"react-circular-progressbar": "../",
"react-dom": "^16.9.0",
"react-dom": "^18.0.0",
"react-move": "^5.2.1",
"react-scripts": "3.4.1",
"react-scripts": "^5.0.0",
"typescript": "3.4.4"
},
"scripts": {
Expand Down
8 changes: 4 additions & 4 deletions demo/src/Demo.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,10 @@ const Code: React.FunctionComponent<React.HTMLProps<HTMLSpanElement>> = (props)
<code className={classNames('p-1 bg-yellow text-dark', props.className)} {...props} />
);

const Example: React.FunctionComponent<{ description: React.ReactNode }> = ({
description,
children,
}) => (
const Example: React.FunctionComponent<{
description: React.ReactNode;
children: React.ReactNode;
}> = ({ description, children }) => (
<div className="col-12 col-sm-6 col-md-4 mt-5">
<div className="row">
<div className="col-6 col-md-4 offset-3 offset-md-4">{children}</div>
Expand Down
Loading