Add support for xbacklight on Linux #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows for changing the brightness without sudoing Debian/Ubuntu users can install using `apt-get install xbacklight`
sindresorhus
suggested changes
Apr 24, 2017
| var Promise = require('pinkie-promise'); | ||
|
|
||
| function get() { | ||
| return new Promise(function (resolve, reject) { |
There was a problem hiding this comment.
There's no need to wrap a promise in another promise.
| @@ -0,0 +1,24 @@ | |||
| var xbacklight = require('xbacklight'); | |||
| var Promise = require('pinkie-promise'); | |||
There was a problem hiding this comment.
This is no longer needed as this module targets Node.js 4 now.
|
What's the benefit of this over the existing Linux implementation? |
|
Doesn't require sudo rights |
|
But it does require a manual |
|
ping @bencevans |
|
Shall try to take a look soon. |
|
I'm no longer using this so shall close the pull-request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for changing the brightness without sudoing
Debian/Ubuntu users can install using
apt-get install xbacklight