Update Lato fonts on desktop #4245
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These newer files don't have a line-height issue where an empty line measures shorter than a line with a character in it.
With updated Lato fonts, this isn't necessary.
|
Update: Marco pointed out that these fonts get included on mobile too. I'll look into whether this introduces visual issues on that side. |
|
Arggghh, it appears that using FontSquirrel w/ "Auto-Adjust Vertical Metrics" causes the empty line sizing issue 😢 |
|
Update: I'm seeing some native differences, but this may be because the |
|
RN 0.33 fixes the line-height issue. We should revisit this once we're upgraded. |
5 tasks
|
Closing since we'll be updating fonts in another PR soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into some really weird behavior in textareas: a blank line was measuring vertical height differently from a line containing a character. I recalled that Lato got a big update a while back, including more glyphs and some fixes to the metrics.
Replacing our current Lato fonts with the updated version fixed the weird behavior I was seeing, as well as adds a few nice things:
Ligatures!
Better strikeout!
(before)
(after)
I've looked into the impact of this by performing a local visdiff run and the effect appears very minor. The biggest change I noticed was a vertical alignment change on the "New private folder" button in the menubar, which I was able to fix by removing a
line-height: 0hack 👍Intentionally not updating mobile here, because there were different font glitches that were a concern. If this works well we can revisit on mobile and give it a detailed look.
👓 @keybase/react-hackers