Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve scan-proofs #4286

Merged
merged 4 commits into from
Sep 16, 2016
Merged

Improve scan-proofs #4286

merged 4 commits into from
Sep 16, 2016

Conversation

mlsteele
Copy link
Contributor

  1. In the case where a sighint doesn't exist on the server, that error was getting dropped on the floor. It should have been marked as a client failure. This actually probably makes up a good portion of the server=no,client=ok cases that I was seeing. Those were the reason for making proofd check PERM_FAILUREs in the first place. So, whoops. Some of those were valid, just not the ~5000 count that were due to this bug. Anyway, fixed.
  2. Saving the cache is pretty slow because it's 16MB (~2s). This update makes it save only when something has changed. Sqlite would be better, but I don't it's worth it.
  3. Skip deleted users.

r? @maxtaco

@maxtaco
Copy link
Contributor

maxtaco commented Sep 16, 2016

👍

@maxtaco
Copy link
Contributor

maxtaco commented Sep 16, 2016

Sorry this took so long!

@mlsteele mlsteele merged commit 1411c49 into master Sep 16, 2016
@mlsteele mlsteele deleted the miles/scan-proofs branch September 16, 2016 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants