-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates react native to 0.34 and cleans up the dev menu #4453
Merged
Merged
Changes from 11 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
28d04ee
ios working. using objc for native code. qr code on ios is NOT workin…
chrisnojima bc26ecd
dont need this intent setup, already works w/o it
chrisnojima ad23dc0
turn off audio on qr code scan. adding new ios 10 camera description …
chrisnojima 8eb0944
add back npm shrinkwrap
chrisnojima eafa2e1
remove unused swift include
chrisnojima 9d03cc8
remove native dev menu. move buttons over to dumb sheet. fix off by o…
chrisnojima 0c81d35
moved text to dumb sheet
chrisnojima 77c2cb4
moved colors to dumb sheet
chrisnojima 1ca8f63
move dumb sheet and cleanup
chrisnojima a7e97e6
add log send to mobile
chrisnojima d1c2b96
fixup android build. remove permissions module as this is built into …
chrisnojima 3ac4e6a
try and fix circle
chrisnojima ca15c63
Try using oraclejdk8
MarcoPolo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,7 +9,6 @@ | |
import android.util.Log; | ||
import android.view.KeyEvent; | ||
|
||
import com.burnweb.rnpermissions.RNPermissionsPackage; | ||
import com.facebook.react.ReactActivity; | ||
import com.facebook.react.ReactInstanceManager; | ||
import com.facebook.react.ReactRootView; | ||
|
@@ -33,11 +32,6 @@ public class MainActivity extends ReactActivity { | |
@TargetApi(Build.VERSION_CODES.KITKAT) | ||
protected void onCreate(Bundle savedInstanceState) { | ||
logFile = this.getFileStreamPath("android.log"); | ||
if (android.os.Build.VERSION.SDK_INT >= android.os.Build.VERSION_CODES.M && !Settings.canDrawOverlays(this) && this.getUseDeveloperSupport()) { | ||
Intent intent = new Intent(Settings.ACTION_MANAGE_OVERLAY_PERMISSION, Uri.parse("package:" + getPackageName())); | ||
startActivityForResult(intent, -1); | ||
} | ||
|
||
initOnce(this.getFilesDir().getPath(), logFile.getAbsolutePath(), "staging", false); | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. seemingly works fine without this. This is setup in other RN code so i think we don't need to do this ourselves anymore |
||
try { | ||
|
@@ -62,12 +56,6 @@ public boolean onKeyUp(int keyCode, KeyEvent event) { | |
} | ||
return super.onKeyUp(keyCode, event); | ||
} | ||
// For dealing with permissions using RNPermissionsPackage | ||
@Override | ||
public void onRequestPermissionsResult(int requestCode, String[] permissions, int[] grantResults) { | ||
RNPermissionsPackage.onRequestPermissionsResult(requestCode, permissions, grantResults); | ||
super.onRequestPermissionsResult(requestCode, permissions, grantResults); | ||
} | ||
|
||
/** | ||
* Returns the name of the main component registered from JavaScript. | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
// | ||
// AppDelegate.h | ||
// Keybase | ||
// | ||
// Created by Chris Nojima on 9/28/16. | ||
// Copyright © 2016 Keybase. All rights reserved. | ||
// | ||
|
||
#import <UIKit/UIKit.h> | ||
|
||
@class Engine; | ||
|
||
@interface AppDelegate : UIResponder <UIApplicationDelegate> | ||
|
||
@property (nonatomic, strong) UIWindow *window; | ||
@property (nonatomic, strong) Engine * engine; | ||
|
||
@end |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is pretty slow so i removed it. less safe but takes half the time to webpack build