Correctly pass task object into thread, fixing race condition #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jpalley good catch! Thanks for that. Could you update your PR and make rubocop happy? |
|
Ah - I tried to get away with just editing it in the github built-in editor! Great project, btw. Makes our life so much easier to deploy rails on cloud run! |
|
@jpalley Looks like our dear rubocop is still unhappy 😆 Note you can run it locally with |
|
Hopefully that did the trick... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RedisTask object is not properly passed into the processing queue thread in the local_server. In our environment this creates a race condition which causes the local_server to randomly fail.