Improve e2e test and fix explicit number conversions

keyshade-xyz · Jul 28, 2024 · eb932cf · eb932cf
1 parent 5b1e31f
commit eb932cf
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/apps/api/src/integration/integration.e2e.spec.ts b/apps/api/src/integration/integration.e2e.spec.ts
@@ -26,6 +26,7 @@ import { MAIL_SERVICE } from '../mail/services/interface.service'
 import { MockMailService } from '../mail/services/mock.service'
 import { EnvironmentModule } from '../environment/environment.module'
 import { EnvironmentService } from '../environment/service/environment.service'
+import { QueryTransformPipe } from '../common/query.transform.pipe'
 
 describe('Integration Controller Tests', () => {
   let app: NestFastifyApplication
@@ -66,6 +67,8 @@ describe('Integration Controller Tests', () => {
     projectService = moduleRef.get(ProjectService)
     environmentService = moduleRef.get(EnvironmentService)
 
+    app.useGlobalPipes(new QueryTransformPipe())
+
     await app.init()
     await app.getHttpAdapter().getInstance().ready()
   })
@@ -602,7 +605,7 @@ describe('Integration Controller Tests', () => {
   it('should be able to fetch all integrations on first page', async () => {
     const result = await app.inject({
       method: 'GET',
-      url: `/integration/all/${workspace1.id}`,
+      url: `/integration/all/${workspace1.id}?page=0&limit=10`,
       headers: {
         'x-e2e-user-email': user1.email
       }
@@ -613,6 +616,7 @@ describe('Integration Controller Tests', () => {
 
     //check metadata
     const metadata = result.json().metadata
+    expect(metadata.totalCount).toEqual(1)
     expect(metadata.links.self).toEqual(
       `/integration/all/${workspace1.id}?page=0&limit=10&sort=name&order=asc&search=`
     )

diff --git a/apps/api/src/integration/service/integration.service.ts b/apps/api/src/integration/service/integration.service.ts
@@ -297,7 +297,7 @@ export class IntegrationService {
         ]
       },
       skip: page * limit,
-      take: Number(limit),
+      take: limit,
       orderBy: {
         [sort]: order
       }
@@ -323,8 +323,8 @@ export class IntegrationService {
       }
     })
     const metadata = paginate(totalCount, `/integration/all/${workspaceId}`, {
-      page: Number(page),
-      limit: Number(limit),
+      page,
+      limit,
       sort,
       order,
       search