refactor: merge handleOAuthLogin

keyshade-xyz · Mar 2, 2024 · fecee8b · fecee8b
1 parent 572d369
commit fecee8b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 21 deletions.
diff --git a/apps/api/src/auth/controller/auth.controller.ts b/apps/api/src/auth/controller/auth.controller.ts
@@ -132,7 +132,7 @@ export class AuthController {
     const { emails, displayName: name, photos } = req.user
     const email = emails[0].value
     const profilePictureUrl = photos[0].value
-    return await this.authService.handleGithubOAuth(
+    return await this.authService.handleOAuthLogin(
       email,
       name,
       profilePictureUrl
@@ -178,7 +178,7 @@ export class AuthController {
     const { emails, displayName: name, photos } = req.user
     const email = emails[0].value
     const profilePictureUrl = photos[0].value
-    return await this.authService.handleGoogleOAuth(
+    return await this.authService.handleOAuthLogin(
       email,
       name,
       profilePictureUrl

diff --git a/apps/api/src/auth/service/auth.service.ts b/apps/api/src/auth/service/auth.service.ts
@@ -111,7 +111,7 @@ export class AuthService {
   }
 
   /* istanbul ignore next */
-  async handleGithubOAuth(
+  async handleOAuthLogin(
     email: string,
     name: string,
     profilePictureUrl: string
@@ -131,24 +131,6 @@ export class AuthService {
     }
   }
 
-  /* istanbul ignore next */
-  async handleGoogleOAuth(
-    email: string,
-    name: string,
-    profilePictureUrl: string
-  ) {
-    const user = await this.createUserIfNotExists(
-      email,
-      name,
-      profilePictureUrl
-    )
-    const token = await this.generateToken(user.id)
-    return {
-      ...user,
-      token
-    }
-  }
-
   /* istanbul ignore next */
   @Cron(CronExpression.EVERY_HOUR)
   async cleanUpExpiredOtps() {