[FEATURE REQUEST]: Add Husky

[rajdip-b]

Is your feature request related to a problem? Please describe.
Add Husky to the project to make pre-commit validations

Describe the solution you'd like
The pre-commit should do the following:

• lint the code for errors
• fix the errors (if fixable)
• run prettier fix on the entire project

[Abbhiishek]

hey @rajdip-b,

i want to work on this feature

[rajdip-b]

@Abbhiishek here you go!

[Abbhiishek]

While doing pnpm install am getting this error:

WARN  Installing a dependency from a non-existent directory: D:\optimus prime\keyshade\@nx\js:library

[Abbhiishek]

[rajdip-b]

That looks odd. I'll try this once on windows and lyk.

[rajdip-b]

Hey @Abbhiishek, I ran it and couldn't find any issues. Mind telling me what command gave you the stack trace error? Also, what's the current RAM on your device?

WARN  Installing a dependency from a non-existent directory: D:\optimus prime\keyshade@nx\js:library

This was fixed by removing the js:library from package.json

[Abbhiishek]

hey @rajdip-b,
removing js:library from package.json resolves the whole issue.
i am able to pnpm install without any errors.

[rajdip-b]

Great to hear! Please do let us know in here if you face any other issues!

[Abbhiishek]

hey @rajdip-b i have made the initial setup for husky ... need some insight on the scripts we need to run for precommit.

Looking at the package.json file :

    "lint": "nx run-many -t lint --parallel",
    "lint:api": "nx run api:lint",
    "lint:web": "nx run web:lint",
    "lint:workspace": "nx run workspace:lint",
    "lint:cli": "nx run cli:lint",
    "lint:sdk-node": "nx run sdk-js:lint",
    "lint:fix": "nx run-many -t lint --fix --parallel",

I suppose we need to run lint and lint:fix for every commit right?

[Abbhiishek]

I tried running pnpm lint:fix and here are the insights

   NX   Ran target lint for 7 projects (1s)                                                                                                    
                                                                                                                                            
   With additional flags:                                                                                                                 
       --fix=true                                                                                                                           
                                                                                                                                            
√    6/7 succeeded [6 read from cache]                                                                                                      
                                                                                                                                            
×    1/7 targets failed, including the following:                                                                                           
     - nx run sdk-rust:lint                                                                                                                 

View structured, searchable error logs at https://nx.app/runs/ecSS0oBnCJ

It successfully run over these apps

[rajdip-b]

yeah there are some issues with rust currently. i would suggest you make the lint:fix command to exclude the rust-sdk module. and then use the lint:fix command in husky.

[kriptonian1]

Hey @Abbhiishek, how is the progress going

[Abbhiishek]

Hey @kriptonian1 i have raise a PR!

[rajdip-b]

🎉 This issue has been resolved in version 1.0.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[rajdip-b]

🎉 This issue has been resolved in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀