Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[User] Log in using Google #4

Closed
rajdip-b opened this issue Dec 25, 2023 · 23 comments · Fixed by #156
Closed

[User] Log in using Google #4

rajdip-b opened this issue Dec 25, 2023 · 23 comments · Fixed by #156
Assignees
@risv1
Labels
help wanted Extra attention is needed scope: api Everything related to the API type: enhancement New feature or request
Milestone
Release v1

Comments

@rajdip-b
Copy link
Member

Users should be able to log into our platform using Google. We will be scraping off the following things from their account:

  • email
  • name
  • profile picture
@rajdip-b rajdip-b converted this from a draft issue Dec 25, 2023
@rajdip-b rajdip-b added type: enhancement New feature or request help wanted Extra attention is needed labels Dec 25, 2023
@rajdip-b rajdip-b added this to the Release v1 milestone Dec 25, 2023
@Abbhiishek
Copy link
Contributor

I would love to work on this

@rajdip-b
Copy link
Member Author

@Abbhiishek Hey man, that's really great! Would you like to pick up #1 first or this?

@Abbhiishek
Copy link
Contributor

Let's start with the first issue

@rajdip-b
Copy link
Member Author

Assigning this to you! Be sure to drop into the Discord channel to have a convo about this (or maybe open a ticket)?

@rajdip-b
Copy link
Member Author

rajdip-b commented Dec 26, 2023 •
edited
Loading

Hey @Abbhiishek, would be nice to know if you understand the flow or not! Plus, updates about this progress as and when you make it would be much appreciated.

@rajdip-b rajdip-b moved this from Todo to In progress in keyshade-api Dec 26, 2023
@rajdip-b
Copy link
Member Author

Ah! my bad! I didn't see your comment properly, :( I'll assign you the first issue!

@rajdip-b rajdip-b added the scope: api Everything related to the API label Dec 26, 2023
@Abbhiishek
Copy link
Contributor

@rajdip-b ✌️

@rajdip-b rajdip-b mentioned this issue Dec 28, 2023
Closed
13 tasks
@rajdip-b rajdip-b moved this from In progress to Todo in keyshade-api Dec 28, 2023
@Abbhiishek Abbhiishek mentioned this issue Dec 29, 2023
Closed
@rajdip-b rajdip-b moved this from Todo to In progress in keyshade-api Dec 29, 2023
@Abbhiishek Abbhiishek mentioned this issue Dec 31, 2023
Closed
10 tasks
@HarshPatel5940
Copy link
Contributor

Note

If someone is proceeding to solve this, also make it optional.
addressing this with respect to #107

@rajdip-b
Copy link
Member Author

rajdip-b commented Feb 4, 2024

@HarshPatel5940 I belive no one is working on this, so you might very well take this up. Also, you can address the issue of #107 in the same PR.

@HarshPatel5940
Copy link
Contributor

@HarshPatel5940 I belive no one is working on this, so you might very well take this up. Also, you can address the issue of #107 in the same PR.

I wanted to wait for a few hours as I am calling for new contributors so they can get started with what's going on with API the least.

I will start working if someone does not take it up by tonight.

@rajdip-b
Copy link
Member Author

rajdip-b commented Feb 4, 2024

I wanted to wait for a few hours as I am calling for new contributors so they can get started with what's going on with API the least.

This would be awesome!

I will start working if someone does not take it up by tonight.

whenever you feel like

@rajdip-b rajdip-b moved this from In progress to Todo in keyshade-api Feb 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2024

Assigned the issue to you!

@HarshPatel5940
Copy link
Contributor

@risv1 check these steps out to make google optional #112 (review)

make a Draft PR, as soon as time permits.

@rajdip-b
Copy link
Member Author

hey folks @HarshPatel5940 @risv1 any updates on this?

@rajdip-b
Copy link
Member Author

Add Google OAuth

@risv1
Copy link
Contributor

risv1 commented Feb 26, 2024

Yes, sorry for the lack of updates, you've provided the link for Trello's API, would you like me to proceed with that or use Passport as mentioned earlier?

@rajdip-b
Copy link
Member Author

Haha I just tracked this issue using trello so it showed up! Keep using passport :)

@risv1
Copy link
Contributor

risv1 commented Feb 26, 2024

Oh alright thanks for the clarification 👍:)

@HarshPatel5940
Copy link
Contributor

@risv1 Give us a tentative deadline, so even you will be responsible with the dates.

@rajdip-b
Copy link
Member Author

Yeah that will definitely help us track it. Considering the fact that @HarshPatel5940 covered most of it, it should be a cakewalk.

#98 check this PR.

@risv1
Copy link
Contributor

risv1 commented Feb 26, 2024

Yeah sure I'll get started with it, will try to get it done asap.

@rajdip-b
Copy link
Member Author

No rush bro

@rajdip-b rajdip-b mentioned this issue Mar 2, 2024
Merged
10 tasks
@github-project-automation github-project-automation bot moved this from Todo to Done in keyshade-api Mar 3, 2024
@rajdip-b
Copy link
Member Author

🎉 This issue has been resolved in version 1.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@risv1 risv1

Labels
help wanted Extra attention is needed scope: api Everything related to the API type: enhancement New feature or request
Projects
keyshade-api
Status: Done
Milestone
Release v1
Development

Successfully merging a pull request may close this issue.

feat(auth): Add Google OAuth risv1/keyshade
4 participants
@rajdip-b @HarshPatel5940 @Abbhiishek @risv1