refactor(api): Update return type while fetching secrets and variables #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajdip-b
requested changes
Jun 8, 2024
rajdip-b
changed the title
|
Format 
|
rajdip-b
requested changes
Jun 9, 2024
This looks perfect! |
rajdip-b
requested changes
Jun 9, 2024
|
@rajdip-b , done!! |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #264 +/- ##
===========================================
- Coverage 91.71% 90.65% -1.06%
===========================================
Files 111 113 +2
Lines 2510 2750 +240
Branches 469 526 +57
===========================================
+ Hits 2302 2493 +191
- Misses 208 257 +49
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
rajdip-b
approved these changes
Jun 9, 2024
rajdip-b
pushed a commit
that referenced
this pull request
Jun 12, 2024
## [2.0.0](v1.4.0...v2.0.0) (2024-06-12) ### ⚠ BREAKING CHANGES * **api:** Refactor environment, [secure] and variable functionality ### 🚀 Features * **platform:** Workspace integrate ([#241](#241)) ([6107e7d](6107e7d)) ### 📚 Documentation * Fix broken links in README.md ([9266788](9266788)) * Modified environment-variable.md ([#256](#256)) ([4974756](4974756)) ### 🔧 Miscellaneous Chores * Added docker build and run commands to` package.json` ([#258](#258)) ([af61791](af61791)) * **api:** Fix inconsistencies in zod schema ([#240](#240)) ([f3a3632](f3a3632)) * **ci:** Update deploy web ([e80d47d](e80d47d)) * **docker:** Grant correct permissions to docker image ([#251](#251)) ([49546aa](49546aa)) * Update GitHub Action plugin versions ([#263](#263)) ([020bbf6](020bbf6)) * Update package versions for release ([93785be](93785be)) ### 🔨 Code Refactoring * **api:** Refactor environment, [secure] and variable functionality ([#270](#270)) ([55a6d37](55a6d37)) * **api:** Replace for loop with array indexing while decrypting [secure]s during bulk fetch [#265](#265) ([#266](#266)) ([62a1731](62a1731)) * **api:** Update return type while fetching [secure]s and variables ([#264](#264)) ([fd36abd](fd36abd))
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
rajdip-b
pushed a commit
that referenced
this pull request
Jun 27, 2024
## [2.0.0](v1.4.0...v2.0.0) (2024-06-12) ### ⚠ BREAKING CHANGES * **api:** Refactor environment, [secure] and variable functionality ### 🚀 Features * **platform:** Workspace integrate ([#241](#241)) ([6107e7d](6107e7d)) ### 📚 Documentation * Fix broken links in README.md ([9266788](9266788)) * Modified environment-variable.md ([#256](#256)) ([4974756](4974756)) ### 🔧 Miscellaneous Chores * Added docker build and run commands to` package.json` ([#258](#258)) ([af61791](af61791)) * **api:** Fix inconsistencies in zod schema ([#240](#240)) ([f3a3632](f3a3632)) * **ci:** Update deploy web ([e80d47d](e80d47d)) * **docker:** Grant correct permissions to docker image ([#251](#251)) ([49546aa](49546aa)) * Update GitHub Action plugin versions ([#263](#263)) ([020bbf6](020bbf6)) * Update package versions for release ([93785be](93785be)) ### 🔨 Code Refactoring * **api:** Refactor environment, [secure] and variable functionality ([#270](#270)) ([55a6d37](55a6d37)) * **api:** Replace for loop with array indexing while decrypting [secure]s during bulk fetch [#265](#265) ([#266](#266)) ([62a1731](62a1731)) * **api:** Update return type while fetching [secure]s and variables ([#264](#264)) ([fd36abd](fd36abd))
yogesh1801
pushed a commit
to yogesh1801/keyshade
that referenced
this pull request
Jun 29, 2024
## [2.0.0](keyshade-xyz/keyshade@v1.4.0...v2.0.0) (2024-06-12) ### ⚠ BREAKING CHANGES * **api:** Refactor environment, [secure] and variable functionality ### 🚀 Features * **platform:** Workspace integrate ([keyshade-xyz#241](keyshade-xyz#241)) ([6107e7d](keyshade-xyz@6107e7d)) ### 📚 Documentation * Fix broken links in README.md ([9266788](keyshade-xyz@9266788)) * Modified environment-variable.md ([keyshade-xyz#256](keyshade-xyz#256)) ([4974756](keyshade-xyz@4974756)) ### 🔧 Miscellaneous Chores * Added docker build and run commands to` package.json` ([keyshade-xyz#258](keyshade-xyz#258)) ([af61791](keyshade-xyz@af61791)) * **api:** Fix inconsistencies in zod schema ([keyshade-xyz#240](keyshade-xyz#240)) ([f3a3632](keyshade-xyz@f3a3632)) * **ci:** Update deploy web ([e80d47d](keyshade-xyz@e80d47d)) * **docker:** Grant correct permissions to docker image ([keyshade-xyz#251](keyshade-xyz#251)) ([49546aa](keyshade-xyz@49546aa)) * Update GitHub Action plugin versions ([keyshade-xyz#263](keyshade-xyz#263)) ([020bbf6](keyshade-xyz@020bbf6)) * Update package versions for release ([93785be](keyshade-xyz@93785be)) ### 🔨 Code Refactoring * **api:** Refactor environment, [secure] and variable functionality ([keyshade-xyz#270](keyshade-xyz#270)) ([55a6d37](keyshade-xyz@55a6d37)) * **api:** Replace for loop with array indexing while decrypting [secure]s during bulk fetch [keyshade-xyz#265](keyshade-xyz#265) ([keyshade-xyz#266](keyshade-xyz#266)) ([62a1731](keyshade-xyz@62a1731)) * **api:** Update return type while fetching [secure]s and variables ([keyshade-xyz#264](keyshade-xyz#264)) ([fd36abd](keyshade-xyz@fd36abd))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated return type while fetching secrets and variables
Fixes #261
Dependencies
Mention any dependencies/packages used
Future Improvements
Mention any improvements to be done in future related to any file/feature
Mentions
Mention and tag the people
Screenshots of relevant screens
Add screenshots of relevant screens
Developer's checklist
If changes are made in the code:
Documentation Update