Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add documentation for scan in CLI #461

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

Allan2000-Git
Copy link
Contributor

@Allan2000-Git Allan2000-Git commented Sep 22, 2024

User description

Description

This PR adds documentation for the new scan feature in the CLI, providing users with clear instructions on how to utilize this functionality effectively.

Fixes #459

Dependencies

No new dependencies introduced.

Future Improvements

Consider adding examples for common use cases of the scan feature in future documentation updates.

Mentions

@rajdip-b

Screenshots of relevant screens

N/A

Developer's checklist

  • My PR follows the style guidelines of this project
  • I have performed a self-check on my work

If changes are made in the code:

  • I have followed the coding guidelines
  • My changes in code generate no new warnings
  • My changes are breaking another fix/feature of the project
  • I have added test cases to show that my feature works
  • I have added relevant screenshots in my PR
  • There are no UI/UX issues

Documentation Update

  • This PR requires an update to the documentation at docs.keyshade.xyz
  • I have made the necessary updates to the documentation, or no documentation changes are required.

PR Type

Documentation


Description

  • Added comprehensive documentation for the new scan command in the CLI.
  • Provided usage instructions and detailed options for scanning files.
  • Aimed to help users detect hardcoded secrets in project files effectively.

Changes walkthrough 📝

Relevant files
Documentation
scan.md
Add documentation for the `scan` CLI command                         

docs/cli/scan.md

  • Added documentation for the scan command in the CLI.
  • Included usage instructions and command options.
  • Described options for scanning specific files or current changes.
  • +25/-0   

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    Copy link
    Contributor

    PR Reviewer Guide 🔍

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No key issues to review

    Copy link
    Contributor

    codiumai-pr-agent-free bot commented Sep 22, 2024

    PR Code Suggestions ✨

    CategorySuggestion                                                                                                                                    Score
    Enhancement
    ✅ Add usage examples for each command option to enhance clarity and usability
    Suggestion Impact:The suggestion to add usage examples for the scan command options was implemented, improving the documentation's clarity.

    code diff:

    +Example:
    +
    +```bash
    +keyshade scan -f path/to/your/file.js
    +```
    +
     ### `-c, --current-changes`
     
     Scan only the current changed files that are not committed.
    +
    +Example:
    +
    +```bash
    +keyshade scan -c
    +```

    Consider adding a brief example of how to use the scan command with each option to
    make the documentation more practical and user-friendly.

    docs/cli/scan.md [19-25]

     ### `-f, --file <string>`
     
     Scan a specific file.
    +
    +Example:
    +```bash
    +keyshade scan -f path/to/your/file.js
    +```
     
     ### `-c, --current-changes`
     
     Scan only the current changed files that are not committed.
     
    +Example:
    +```bash
    +keyshade scan -c
    +```
    +
    • Apply this suggestion
    Suggestion importance[1-10]: 8

    Why: Adding examples for each command option significantly improves the documentation's clarity and usability, making it easier for users to understand how to use the command effectively.

    8
    Provide information about the expected output of the scan command

    Consider adding information about the output format or what users can expect after
    running the scan command.

    docs/cli/scan.md [5-13]

     # `scan`
     
     The `scan` command is used to detect any hardcoded secrets in your project files. It can scan specific files, only changed files, or all files in the project.
     
     ## Usage
     
     ```bash
     keyshade scan [options]

    +After running the scan, the command will output a list of detected secrets, if any, including their location and type. If no secrets are found, it will display a success message.
    +

    
    - [ ] **Apply this suggestion** <!-- /improve --apply_suggestion=1 -->
    
    <details><summary>Suggestion importance[1-10]: 8</summary>
    
    Why: Describing the expected output of the command helps users know what to look for after execution, enhancing the documentation's completeness and user experience.
    
    
    </details></details></td><td align=center>8
    
    </td></tr><tr><td>
    
    
    
    <details><summary>Explain the default behavior of the scan command when no options are provided<!-- not_implemented --></summary>
    
    ___
    
    
    **Consider adding information about the default behavior of the <code>scan</code> command when no <br>options are specified.**
    
    [docs/cli/scan.md [15-25]](https://github.com/keyshade-xyz/keyshade/pull/461/files#diff-4c9cc9e2c50e5ec27e10277c0a92db149bf5ae71aa4958e68bfb191935470cc8R15-R25)
    
    ```diff
     ## Options
     
     These are the options supported by the `scan` command:
    +
    +### Default behavior
    +
    +When no options are specified, the `scan` command will scan all files in the project.
     
     ### `-f, --file <string>`
     
     Scan a specific file.
     
     ### `-c, --current-changes`
     
     Scan only the current changed files that are not committed.
     
    
    • Apply this suggestion
    Suggestion importance[1-10]: 7

    Why: Including information about the default behavior when no options are specified is useful for users to understand the command's full functionality, though it is not as crucial as providing examples.

    7

    💡 Need additional feedback ? start a PR chat

    @rajdip-b rajdip-b changed the title docs: add documentation for scan in CLI docs: Add documentation for scan in CLI Sep 22, 2024
    @Allan2000-Git Allan2000-Git force-pushed the docs/scan branch 3 times, most recently from 88e1e65 to 7cb7d29 Compare September 22, 2024 13:30
    @rajdip-b rajdip-b merged commit 72281e6 into keyshade-xyz:develop Sep 23, 2024
    5 checks passed
    Allan2000-Git added a commit to Allan2000-Git/keyshade that referenced this pull request Sep 23, 2024
    Meeran-Tofiq pushed a commit to Meeran-Tofiq/keyshade that referenced this pull request Sep 29, 2024
    Kiranchaudhary537 pushed a commit to Kiranchaudhary537/keyshade that referenced this pull request Oct 13, 2024
    rajdip-b pushed a commit that referenced this pull request Oct 24, 2024
    ## [2.6.0](v2.5.0...v2.6.0) (2024-10-24)
    
    ### 🚀 Features
    
    * **api:**  Add icon and remove description field from workspace ([#435](#435)) ([a99c0db](a99c0db))
    * **api-client:** Added workspace-membership and related tests ([#452](#452)) ([6a1c091](6a1c091))
    * **api-client:** Create controller for User module ([#484](#484)) ([f9d8e83](f9d8e83))
    * **api:** Add prod env schema in env file ([#436](#436)) ([21c3004](21c3004))
    * **api:** Add resend otp implementation ([#445](#445)) ([4dc6aa1](4dc6aa1))
    * **api:** Fetch total count of environments, [secure]s and variables in project ([#434](#434)) ([0c9e50a](0c9e50a))
    * **api:** Replace `projectId` with `name` and `slug` in workspace-role response.  ([#432](#432)) ([af06071](af06071))
    * **cli:** Add functionality to operate on Secrets ([#504](#504)) ([1b4bf2f](1b4bf2f))
    * **cli:** Add project command ([#451](#451)) ([70448e1](70448e1))
    * **cli:** Add workspace operations ([#441](#441)) ([ed38d22](ed38d22))
    * **cli:** implement commands to get, list, update, and delete, workspace roles ([#469](#469)) ([957ea8d](957ea8d))
    * **cli:** Implemented pagination support ([#453](#453)) ([feb1806](feb1806))
    * **cli:** Secret scan ([#438](#438)) ([85cb8ab](85cb8ab))
    * **cli:** Update environment command outputs ([f4af874](f4af874))
    * **platform:** Clearing email field after waitlisting the user email ([#481](#481)) ([256d659](256d659))
    * Remove project IDs from workspace role export data and update tests ([#448](#448)) ([8fdb328](8fdb328))
    * **web:** Configured extra check for waitlisted users already in the list and created toast message for them ([#492](#492)) ([2ddd0ef](2ddd0ef))
    * **web:** show the toast only when email add successfully ([#490](#490)) ([783c411](783c411))
    
    ### 🐛 Bug Fixes
    
    * **api,api-client:** Add environmentSlug in multiple places across the variable module ([#468](#468)) ([d970aff](d970aff))
    * **api:** Replace the id with slug in the global-search service ([#455](#455)) ([74804b1](74804b1))
    * **platform:** Fixed duplicate Google Logo UI fix  ([#450](#450)) ([fb0d6f7](fb0d6f7))
    * resolve footer website name cut-off or overlap issue ([#444](#444)) ([fe03ba2](fe03ba2))
    * **web:** Horizontal Scrolling issue on the website ([#440](#440)) ([655177b](655177b))
    
    ### 📚 Documentation
    
    * Add documentation for environment in CLI ([#462](#462)) ([dad7394](dad7394))
    * Add documentation for project in CLI ([#466](#466)) ([341fb32](341fb32))
    * Add documentation for scan in CLI ([#461](#461)) ([72281e6](72281e6))
    * Add documentation for workspace command ([#464](#464)) ([4aad8a2](4aad8a2))
    * Add instructions for resetting the local Prisma database ([#495](#495)) ([#501](#501)) ([b07ea17](b07ea17))
    * Added docker support documentation ([#465](#465)) ([bc04be4](bc04be4))
    * Added documentation for running the platform ([#473](#473)) ([8b8386b](8b8386b))
    * Added missing mappings to pages ([5de9fd8](5de9fd8))
    * Fix Documentation Hyperlink and update expired Discord invite link ([#496](#496)) ([5a10e39](5a10e39))
    * Updated CLI docs ([#460](#460)) ([c7e0f13](c7e0f13))
    
    ### 🔧 Miscellaneous Chores
    
    * Add more logging to Sentry init ([#470](#470)) ([de4925d](de4925d))
    * **api:** Optimise API docker image size ([#360](#360)) ([ea40dc1](ea40dc1))
    * **api:** Updated lockfile ([a968e78](a968e78))
    * **CI:** Add [secure] scan validation ([f441262](f441262))
    * **cli:** Update controller invocation in environment commands ([#477](#477)) ([596bd1a](596bd1a))
    * Minor changes to variables ([fe01ca6](fe01ca6))
    * **[secure]-scan:** Failing lint issues ([#507](#507)) ([48f45df](48f45df))
    * **[secure]-scan:** Formatted files ([5884833](5884833))
    * Update .env.example ([70ad4f7](70ad4f7))
    * Updated scripts ([9eb76a7](9eb76a7))
    * **web:** email validation ([#487](#487)) ([e8e737a](e8e737a))
    @rajdip-b
    Copy link
    Member

    🎉 This PR is included in version 2.6.0 🎉

    The release is available on GitHub release

    Your semantic-release bot 📦🚀

    @Allan2000-Git Allan2000-Git deleted the docs/scan branch December 20, 2024 12:57
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    DOCS: Add docs for scan in CLI
    2 participants