Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix for win32 jna in java bindings. #408

Merged
merged 1 commit into from
Aug 2, 2019
Merged

Bug fix for win32 jna in java bindings. #408

merged 1 commit into from
Aug 2, 2019

Conversation

zhkl0228
Copy link
Contributor

Bug fix for win32 jna access

@zhkl0228
Bug fix
e7fb58a 
Bug fix for win32 jna access
@zhkl0228 zhkl0228 changed the title Bug fix Java bindings Mar 14, 2019
@zhkl0228 zhkl0228 changed the title Java bindings Bug fix for win32 jna access in java bindings. Mar 14, 2019
@zhkl0228 zhkl0228 changed the title Bug fix for win32 jna access in java bindings. Bug fix for win32 jna in java bindings. Mar 14, 2019
@JamesMenetrey
Copy link
Contributor

Hey @zhkl0228,

Many thanks for the submit. I checked the signature of ks_asm in the original .h and the type of the address parameter is indeed a 64-bit integer. I have successfully run the unit tests. Nicely spotted!

@aquynh This is ok for me.

Thanks

Cheers,
ZenLulz

@aquynh aquynh merged commit 34fcbe4 into keystone-engine:master Aug 2, 2019
@aquynh
Copy link
Member

aquynh commented Aug 2, 2019

merged, thanks!

bon96 added a commit to bon96/keystone that referenced this pull request Aug 18, 2021
@bon96
Treat address as 64 bit integer to match native call. Related to keys…
38495da 
…tone-engine#408
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhkl0228 @JamesMenetrey @aquynh