-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove object format #81
base: master
Are you sure you want to change the base?
Conversation
This will take more time to review. Will get back to you asap, thanks! |
@@ -159,8 +155,6 @@ MCSymbol *MCContext::createSymbolImpl(const StringMapEntry<bool> *Name, | |||
switch (MOFI->getObjectFileType()) { | |||
case MCObjectFileInfo::IsELF: | |||
return new (Name, *this) MCSymbolELF(Name, IsTemporary); | |||
case MCObjectFileInfo::IsMachO: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this switch now has only one case, so can be removed
very nice work. i just saw a minor issue. please fix that, and then we can merge this, thanks! |
i fixed that switch, merged & pushed to a new branch "cleanup" at https://github.com/keystone-engine/beta/tree/cleanup. there is an issue however: now suite/regress/regress.py crashes with below message. can you look at that?
|
Actually, I'm also getting that assertion on the 'master' branch, these changes weren't merged in master yet right? |
git bisect tells me the assertion error happens because of this commit:
The check I used was: |
I see, but since the master branch has no issue with that commit, so this
PR does something wrong?
|
Update: The assertion happens in both master and cleanup branch, but only when making a debug build (which makes sense as assert is a nop without NDEBUG). |
i syned "cleanup" with "master", but now it fails to compile. the error is from llvm/lib/MC/MCParser/DarwinAsmParser.cpp, and it happens when it links to /usr/local/include/llvm/MC/MCSectionMachO.h. this is a big problem, since it is supposed to link to local file MCSectionMachO.h, not the one from /usr/. could you take a look at this? |
fixed so x64_nasm_default_rel.py passed in "master" now. |
Remove code for COFF/MachO code, remove the now unneeded ObjectFormat from Triple and remove the Darwin exceptions in PPCAsmParser. Refs #31