Skip to content
This repository has been archived by the owner on Aug 6, 2024. It is now read-only.

feat: use correct pkg manager when creating keystone app #427

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 16 additions & 24 deletions create-keystone-app/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -47,32 +47,24 @@ async function normalizeArgs(): Promise<Args> {
};
}

const installDeps = async (cwd: string): Promise<'yarn' | 'npm'> => {
function pkgManagerFromUserAgent(userAgent: string | undefined) {
if (!userAgent) return 'npm';
const pkgSpec = userAgent.split(' ')[0];
const [name, _version] = pkgSpec.split('/');
return name ?? 'npm';
}
Comment on lines +50 to +55
Copy link
Contributor Author

@iamandrewluca iamandrewluca Jan 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


const installDeps = async (cwd: string): Promise<string> => {
const pkgManager = pkgManagerFromUserAgent(process.env.npm_config_user_agent);
const spinner = ora(
'Installing dependencies with yarn. This may take a few minutes.'
`Installing dependencies with ${pkgManager}. This may take a few minutes.`
).start();
try {
await execa('yarn', ['install'], { cwd });
spinner.succeed('Installed dependencies with yarn.');
return 'yarn';
} catch (_err: any) {
let err: ExecaError = _err;
if (err.failed) {
process.stdout.write('\n');
spinner.warn('Failed to install with yarn.');
spinner.start(
'Installing dependencies with npm. This may take a few minutes.'
);
try {
await execa('npm', ['install'], { cwd });
spinner.succeed('Installed dependencies with npm.');
} catch (npmErr) {
spinner.fail('Failed to install with npm.');
throw npmErr;
}
process.stdout.write('\n');
return 'npm';
}
await execa(pkgManager, ['install'], { cwd });
spinner.succeed(`Installed dependencies with ${pkgManager}.`);
return pkgManager;
} catch (err) {
spinner.fail(`Failed to install with ${pkgManager}.`);
throw err;
}
};
Expand Down Expand Up @@ -113,7 +105,7 @@ const installDeps = async (cwd: string): Promise<'yarn' | 'npm'> => {
${c.bold('To launch your app, run:')}

- cd ${relativeProjectDir}
- ${packageManager === 'yarn' ? 'yarn' : 'npm run'} dev
- ${packageManager} run dev

${c.bold('Next steps:')}

Expand Down