Skip to content

Commit

Permalink
merge aria-description text into aria-label (#6412)
Browse files Browse the repository at this point in the history
* merge aria-description text into aria-label

* chnageset
  • Loading branch information
gwyneplaine authored Aug 26, 2021
1 parent 292ea26 commit 2324fa0
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 10 deletions.
5 changes: 5 additions & 0 deletions .changeset/spotty-ducks-wonder.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@keystone-next/keystone': patch
---

Merged aria-description text for dialogs on list view in Admin UI into their respective aria-labels.
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,7 @@ export function FieldSelection({

return (
<Popover
aria-label="Columns options"
aria-description={`list of column options to apply to the ${list.key} list`}
aria-label={`Columns options, list of column options to apply to the ${list.key} list`}
triggerRenderer={({ triggerProps }) => {
return (
<Button weight="link" css={{ padding: 4 }} {...triggerProps}>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,7 @@ export function FilterAdd({ listKey }: { listKey: string }) {
<ChevronDownIcon size="small" />
</Button>
<PopoverDialog
aria-label="Filters options"
aria-description={`list of filters to apply to the ${listKey} list`}
aria-label={`Filters options, list of filters to apply to the ${listKey} list`}
arrow={arrow}
isVisible={isOpen}
{...dialog.props}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,8 @@ function FilterPill({ filter, field }: { filter: Filter; field: FieldMeta }) {
<Fragment>
<Pill
containerProps={{
'aria-label': `Filter item ${filter.field}`,
'aria-label': `Filter item ${filter.field}, press to edit filter`,
}}
aria-description={'Press to edit filter'}
{...trigger.props}
ref={trigger.ref}
onClick={() => setOpen(true)}
Expand All @@ -64,8 +63,7 @@ function FilterPill({ filter, field }: { filter: Filter; field: FieldMeta }) {
/>
</Pill>
<PopoverDialog
aria-label="filter item config"
aria-description={`dialog for configuring ${filter.field} filter`}
aria-label={`filter item config, dialog for configuring ${filter.field} filter`}
arrow={arrow}
{...dialog.props}
isVisible={isOpen}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,7 @@ export function SortSelection({ list }: { list: ListMeta }) {
</Button>

<PopoverDialog
aria-label="Sort options"
aria-description={`list of sorting parameters to apply to the ${list.key} list`}
aria-label={`Sort options, list of sorting parameters to apply to the ${list.key} list`}
arrow={arrow}
isVisible={isOpen}
{...dialog.props}
Expand Down

0 comments on commit 2324fa0

Please sign in to comment.