Skip to content

Commit

Permalink
Fix issue with VisuallyHidden checkbox interactions in table (#6334)
Browse files Browse the repository at this point in the history
* resolve CHROME BUG

* changeset
  • Loading branch information
gwyneplaine authored Aug 17, 2021
1 parent 0a7b0f7 commit f3014a6
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 3 deletions.
5 changes: 5 additions & 0 deletions .changeset/dirty-cheetahs-guess.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@keystone-next/keystone': patch
---

Resolved bug with visually hidden elements in ListView checkboxes expanding to fill the whole body on click of elements near the bottom of the screen.
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,6 @@ const ListPage = ({ listKey }: ListPageProps) => {

const theme = useTheme();
const showCreate = !(metaQuery.data?.keystone.adminMeta.list?.hideCreate ?? true) || null;

return (
<PageContainer header={<ListPageHeader listKey={listKey} />}>
{metaQuery.error ? (
Expand Down Expand Up @@ -523,7 +522,6 @@ function ListTable({
const { query } = useRouter();
const shouldShowLinkIcon =
!list.fields[selectedFields.keys().next().value].views.Cell.supportsLinkTo;

return (
<Box paddingBottom="xlarge">
<TableContainer>
Expand Down Expand Up @@ -614,7 +612,7 @@ function ListTable({
minHeight: 38,
alignItems: 'center',
justifyContent: 'start',
// cursor: 'pointer',
position: 'relative',
}}
>
<CheckboxControl
Expand Down Expand Up @@ -742,6 +740,7 @@ const TableHeaderCell = (props: HTMLAttributes<HTMLElement>) => {
padding: spacing.small,
textAlign: 'left',
position: 'sticky',
zIndex: 1,
top: 0,
}}
{...props}
Expand Down

0 comments on commit f3014a6

Please sign in to comment.