Convert GraphQL SDL to AST before passing to Apollo #1341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset is good to goLatest commit: 094f271 We got this. Not sure what this means? Click here to learn what changesets are. |
Apollo released a breaking change in a semver-minor which causes it to stop understanding the SDL (string) GraphQL typeDefs we were passing it. This fix ensures we're converting to an AST to avoid the error being thrown. See apollographql/apollo-server#2921 Fixes #1340
jesstelford
force-pushed
the
fix-apollo-bug
branch
from
f50385e to
094f271
Compare
|
Sorry! It wasn't intended to be a breaking change, and we still plan on supporting |
|
Not to worry - these things happen! Thanks for getting the fix into Apollo core so quick 👍 I'll still push this release for Keystone 5 through just in case. |
|
Fix released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apollo released a breaking change in a semver-minor which causes it to
stop understanding the SDL (string) GraphQL typeDefs we were passing it.
This fix ensures we're converting to an AST to avoid the error being
thrown.
See apollographql/apollo-server#2921
Fixes #1340