-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix TypeScript errors #6061
Fix TypeScript errors #6061
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/keystonejs/keystone-next-docs/AVnfjdpiMa9JzEvhG591rHzshXZx |
🦋 Changeset detectedLatest commit: 6b39853 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@@ -3,7 +3,7 @@ import { schema } from '.'; | |||
const identity = (x: any) => x; | |||
|
|||
export const impls = { | |||
equalityConditions<T>(fieldKey: string, f: (a: any) => any = identity) { | |||
equalityConditions<T>(fieldKey: string, f: (a: any) => any = identity): any { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These things are because TypeScript generates declarations that are broken but having actual types for the returns types here doesn't matter.
@@ -17,6 +17,7 @@ | |||
"dependencies": { | |||
"@babel/runtime": "^7.14.6", | |||
"@emotion/react": "^11.4.0", | |||
"@types/facepaint": "1.2.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is because the @types
packages make the things work globally so we didn't catch that the type is used in the generated declarations do this dep is needed
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
No description provided.