Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TypeScript errors #6061

Merged
merged 2 commits into from
Jul 7, 2021
Merged

Fix TypeScript errors #6061

merged 2 commits into from
Jul 7, 2021

Conversation

emmatown
Copy link
Member

@emmatown emmatown commented Jul 7, 2021

No description provided.

@vercel
Copy link

vercel bot commented Jul 7, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/keystonejs/keystone-next-docs/AVnfjdpiMa9JzEvhG591rHzshXZx
✅ Preview: https://keystone-next-docs-git-fix-typescript-errors-keystonejs.vercel.app

@changeset-bot
Copy link

changeset-bot bot commented Jul 7, 2021

🦋 Changeset detected

Latest commit: 6b39853

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@keystone-ui/core Patch
@keystone-next/types Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@@ -3,7 +3,7 @@ import { schema } from '.';
const identity = (x: any) => x;

export const impls = {
equalityConditions<T>(fieldKey: string, f: (a: any) => any = identity) {
equalityConditions<T>(fieldKey: string, f: (a: any) => any = identity): any {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These things are because TypeScript generates declarations that are broken but having actual types for the returns types here doesn't matter.

@@ -17,6 +17,7 @@
"dependencies": {
"@babel/runtime": "^7.14.6",
"@emotion/react": "^11.4.0",
"@types/facepaint": "1.2.1",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is because the @types packages make the things work globally so we didn't catch that the type is used in the generated declarations do this dep is needed

@vercel vercel bot temporarily deployed to Preview July 7, 2021 00:19 Inactive
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 7, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@emmatown emmatown requested a review from a team July 7, 2021 00:30
@emmatown emmatown merged commit 5f3d407 into master Jul 7, 2021
@emmatown emmatown deleted the fix-typescript-errors branch July 7, 2021 00:32
Nikitoring pushed a commit to Nikitoring/keystone that referenced this pull request Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants