Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary GraphQL descriptions #6105

Merged
merged 3 commits into from
Jul 16, 2021

Conversation

emmatown
Copy link
Member

These descriptions just repeat what's in the name and don't actually add any new information so having a smaller schema that's easier to read at a glance is better imo

note: major because a build that would succeed with the current version would fail since the schema.graphql file would have to be updated.

@emmatown emmatown requested a review from a team July 15, 2021 01:41
@vercel
Copy link

vercel bot commented Jul 15, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/keystonejs/keystone-next-docs/ECX3H2g52iqbQqyw91W64ZcBx6TN
✅ Preview: https://keystone-next-docs-git-remove-unnecessary-gra-e362d3-keystonejs.vercel.app

@changeset-bot
Copy link

changeset-bot bot commented Jul 15, 2021

🦋 Changeset detected

Latest commit: a7e5746

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
@keystone-next/fields Major
@keystone-next/keystone Major
@keystone-next/example-assets-cloud Patch
@keystone-next/example-assets-local Patch
@keystone-next/example-auth Patch
@keystone-next/examples-app-basic Patch
@keystone-next/example-ecommerce Patch
@keystone-next/example-embedded-nextjs Patch
keystone-next-app Patch
@keystone-next/example-playground Patch
@keystone-next/example-roles Patch
@keystone-next/example-sandbox Patch
@keystone-next/example-blog Patch
@keystone-next/example-custom-field-view Patch
@keystone-next/example-custom-field Patch
@keystone-next/example-default-values Patch
@keystone-next/example-document-field Patch
@keystone-next/example-extend-graphql-schema Patch
@keystone-next/example-json-field Patch
@keystone-next/example-task-manager Patch
@keystone-next/example-testing Patch
@keystone-next/example-virtual-field Patch
@keystone-next/example-with-auth Patch
@keystone-next/auth Major
@keystone-next/cloudinary Patch
@keystone-next/fields-document Patch
@keystone-next/types Patch
@keystone-next/benchmarks-legacy Patch
@keystone-next/test-projects-basic Patch
@keystone-next/testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 15, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@vercel vercel bot temporarily deployed to Preview July 15, 2021 01:53 Inactive
Copy link
Contributor

@timleslie timleslie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic!

@vercel vercel bot temporarily deployed to Preview July 16, 2021 00:57 Inactive
@emmatown emmatown enabled auto-merge (squash) July 16, 2021 00:57
@emmatown emmatown merged commit e5f61ad into master Jul 16, 2021
@emmatown emmatown deleted the remove-unnecessary-graphql-descriptions branch July 16, 2021 01:02
Nikitoring pushed a commit to Nikitoring/keystone that referenced this pull request Sep 14, 2021
* Remove unnecessary GraphQL descriptions

* Fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants