Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix virtual field rendering of false & 0 #6110

Merged
merged 4 commits into from
Jul 16, 2021
Merged

Fix virtual field rendering of false & 0 #6110

merged 4 commits into from
Jul 16, 2021

Conversation

ChuckJonas
Copy link
Contributor

@ChuckJonas ChuckJonas commented Jul 15, 2021 •
edited
Loading

0 and false currently don't render when they are returned by virtual fields. Seems like this component could be more "aware" if we were passing in the schema.field type.

@changeset-bot
Copy link

changeset-bot bot commented Jul 15, 2021 •
edited
Loading

🦋 Changeset detected

Latest commit: 907ddbb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@keystone-next/fields Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jul 15, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/keystonejs/keystone-next-docs/ADXRPD1NiAwF51uov8BVSTdEwY7n
✅ Preview: https://keystone-next-docs-git-fork-chuckjonas-fix-vi-f18cf1-keystonejs.vercel.app

@vercel vercel bot temporarily deployed to Preview July 15, 2021 05:22 Inactive
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 15, 2021 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@ChuckJonas
Copy link
Contributor Author

I just tested this using the built libraries above and it seems to be working for both false and 0 now 👍

@ChuckJonas ChuckJonas force-pushed the fix-virtual-falsy-rendering branch from faa7f71 to e6c3327 Compare July 15, 2021 23:44
@vercel vercel bot temporarily deployed to Preview July 15, 2021 23:44 Inactive
@vercel vercel bot temporarily deployed to Preview July 15, 2021 23:49 Inactive
@vercel vercel bot temporarily deployed to Preview July 15, 2021 23:54 Inactive
timleslie
timleslie approved these changes Jul 16, 2021
View reviewed changes
Copy link
Contributor

@timleslie timleslie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all look good, thanks for the PR 🙏

@timleslie timleslie enabled auto-merge (squash) July 16, 2021 00:02
@vercel vercel bot temporarily deployed to Preview July 16, 2021 00:17 Inactive
@timleslie timleslie merged commit 2ef6fe8 into keystonejs:master Jul 16, 2021
@keystonejs-release-bot keystonejs-release-bot mentioned this pull request Jul 16, 2021
Merged
Nikitoring pushed a commit to Nikitoring/keystone that referenced this pull request Sep 14, 2021
@ChuckJonas @Nikitoring
Fix virtual field rendering of false & 0 (keystonejs#6110)
d612ba0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timleslie timleslie timleslie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChuckJonas @timleslie @bladey