Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ui.searchFields option #6165

Merged
merged 8 commits into from
Jul 25, 2021
Merged

Add ui.searchFields option #6165

merged 8 commits into from
Jul 25, 2021

Conversation

emmatown
Copy link
Member

This is primarily to remove the usage of the search argument in the Admin UI because we're planning on removing it soon because people may think that it's proper full-text search which it is not and we recommend people use contains filters directly(which is what the search argument does) until Prisma supports full-text search and we expose it in the GraphQL API.

@vercel
Copy link

vercel bot commented Jul 23, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/keystonejs/keystone-next-docs/Fa2ogVKQjt4DuzE8onEVFSeM9UVu
✅ Preview: https://keystone-next-docs-git-ui-search-fields-keystonejs.vercel.app

@changeset-bot
Copy link

changeset-bot bot commented Jul 23, 2021

🦋 Changeset detected

Latest commit: e197d51

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@keystone-next/fields Major
@keystone-next/keystone Major
@keystone-next/types Major
@keystone-next/example-assets-cloud Patch
@keystone-next/example-assets-local Patch
@keystone-next/example-auth Patch
@keystone-next/examples-app-basic Patch
@keystone-next/example-ecommerce Patch
@keystone-next/example-embedded-nextjs Patch
keystone-next-app Patch
@keystone-next/example-playground Patch
@keystone-next/example-roles Patch
@keystone-next/example-sandbox Patch
@keystone-next/example-blog Patch
@keystone-next/example-custom-admin-ui-logo Patch
@keystone-next/example-custom-field-view Patch
@keystone-next/example-custom-field Patch
@keystone-next/example-default-values Patch
@keystone-next/example-document-field Patch
@keystone-next/example-extend-graphql-schema Patch
@keystone-next/example-json-field Patch
@keystone-next/example-task-manager Patch
@keystone-next/example-testing Patch
@keystone-next/example-virtual-field Patch
@keystone-next/example-with-auth Patch
@keystone-next/auth Major
@keystone-next/cloudinary Patch
@keystone-next/fields-document Patch
@keystone-next/benchmarks-legacy Patch
@keystone-next/test-projects-basic Patch
@keystone-next/testing Patch
@keystone-next/admin-ui-utils Patch
@keystone-next/utils Patch
@keystone-next/admin-ui-tests Patch
@keystone-next/api-tests-legacy Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel vercel bot temporarily deployed to Preview July 23, 2021 02:47 Inactive
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 23, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@vercel vercel bot temporarily deployed to Preview July 23, 2021 03:06 Inactive
@emmatown emmatown marked this pull request as ready for review July 23, 2021 03:29
@vercel vercel bot temporarily deployed to Preview July 23, 2021 03:40 Inactive
Comment on lines +430 to +433
enum QueryMode {
default
insensitive
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note the naming and enum values here align with the mode field that will be in the new filters for strings (and since the new filters align with Prisma, so does this).

@emmatown emmatown requested a review from a team July 23, 2021 03:47
Co-authored-by: Tim Leslie <timl@thinkmill.com.au>
@vercel vercel bot temporarily deployed to Preview July 25, 2021 23:02 Inactive
Copy link
Contributor

@timleslie timleslie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vercel vercel bot temporarily deployed to Preview July 25, 2021 23:27 Inactive
@emmatown emmatown enabled auto-merge (squash) July 25, 2021 23:27
@emmatown emmatown merged commit e4e6cf9 into master Jul 25, 2021
@emmatown emmatown deleted the ui-search-fields branch July 25, 2021 23:37
Nikitoring pushed a commit to Nikitoring/keystone that referenced this pull request Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants