-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from apollo-errors to apollo-server-errors #6200
Conversation
🦋 Changeset detectedLatest commit: 4f164e1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/keystonejs/keystone-next-docs/BcqepPLAgobri2DryJAwkCRGJrRY |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
message: 'Your request exceeded server limits', | ||
options: { showPath: true }, | ||
}); | ||
export const AccessDeniedError = () => new ApolloError('You do not have access to this resource'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you either make all these classes or make the first character in them lowercase?
The only functional difference is that
apollo-server-errors
injectsextensions: { code: undefined }
into the error, but we're not using this field just yet. This change highlights that our error functions were passing through a bunch of extra data which was never being surfaced in our errors. That's fine, since we want re-assess what we're exposing to people anyway. This gives us a nice clean slate to work from.