Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from apollo-errors to apollo-server-errors #6200

Merged
merged 3 commits into from
Jul 27, 2021

Conversation

timleslie
Copy link
Contributor

The only functional difference is that apollo-server-errors injects extensions: { code: undefined } into the error, but we're not using this field just yet. This change highlights that our error functions were passing through a bunch of extra data which was never being surfaced in our errors. That's fine, since we want re-assess what we're exposing to people anyway. This gives us a nice clean slate to work from.

@changeset-bot
Copy link

changeset-bot bot commented Jul 27, 2021

🦋 Changeset detected

Latest commit: 4f164e1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@keystone-next/keystone Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jul 27, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/keystonejs/keystone-next-docs/BcqepPLAgobri2DryJAwkCRGJrRY
✅ Preview: https://keystone-next-docs-git-use-apollo-server-errors-keystonejs.vercel.app

@vercel vercel bot temporarily deployed to Preview July 27, 2021 06:26 Inactive
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 27, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@timleslie timleslie requested a review from a team July 27, 2021 06:31
message: 'Your request exceeded server limits',
options: { showPath: true },
});
export const AccessDeniedError = () => new ApolloError('You do not have access to this resource');
Copy link
Member

@emmatown emmatown Jul 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you either make all these classes or make the first character in them lowercase?

@vercel vercel bot temporarily deployed to Preview July 27, 2021 06:52 Inactive
@timleslie timleslie enabled auto-merge (squash) July 27, 2021 06:57
@timleslie timleslie merged commit 686c0f1 into master Jul 27, 2021
@timleslie timleslie deleted the use-apollo-server-errors branch July 27, 2021 06:58
Nikitoring pushed a commit to Nikitoring/keystone that referenced this pull request Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants