Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve whitespace in errors #6220

Merged
merged 1 commit into from
Jul 29, 2021
Merged

Preserve whitespace in errors #6220

merged 1 commit into from
Jul 29, 2021

Conversation

timleslie
Copy link
Contributor

The aim here is to preserve white-space from the error messages returned by the GraphQL API.

@gwyneplaine Is this the right approach? Are there are places these errors are surfaced that might also need this change?

@vercel
Copy link

vercel bot commented Jul 29, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/keystonejs/keystone-next-docs/4KEHyS9dmiHiiK81KmAJimAxEx2R
✅ Preview: https://keystone-next-docs-git-pre-wrap-errors-keystonejs.vercel.app

@changeset-bot
Copy link

changeset-bot bot commented Jul 29, 2021

🦋 Changeset detected

Latest commit: 178ab4e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@keystone-ui/notice Patch
@keystone-ui/toast Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@timleslie timleslie requested a review from gwyneplaine July 29, 2021 05:32
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

@gwyneplaine gwyneplaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine, let's get this in so we can validate it against the inflight graphql error changes

@timleslie timleslie merged commit c2bb6a9 into master Jul 29, 2021
@timleslie timleslie deleted the pre-wrap-errors branch July 29, 2021 06:05
@gwyneplaine
Copy link
Contributor

Newline works as expected for:

  • Create.
  • Edit.
  • Inline create vie card view.
  • Inline create via nested modal.

Nikitoring pushed a commit to Nikitoring/keystone that referenced this pull request Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants