Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better display for document fields in list view and card view #6705

Merged
merged 16 commits into from
Oct 25, 2021
Merged

Better display for document fields in list view and card view #6705

merged 16 commits into from
Oct 25, 2021

Conversation

oplik0
Copy link
Contributor

@oplik0 oplik0 commented Oct 4, 2021

This change resolves #6522 by serializing documents to plain text for list view. Additionally, I changed the display for card view from JSON to a DocumentRenderer - while the former may be useful to a developer, I feel like many end users are not developers and might be expecting that their rich text will be at least readable.

@vercel
Copy link

vercel bot commented Oct 4, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/keystonejs/keystone-next-docs/CtcpyxDgEdDYvNswK9SkcFAurtAx
✅ Preview: https://keystone-next-docs-git-fork-oplik0-document-f-8bcfe6-keystonejs.vercel.app

@changeset-bot
Copy link

changeset-bot bot commented Oct 4, 2021

🦋 Changeset detected

Latest commit: 887f2a1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@keystone-next/fields-document Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel vercel bot temporarily deployed to Preview October 4, 2021 21:17 Inactive
@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 4, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@vercel vercel bot temporarily deployed to Preview October 4, 2021 21:41 Inactive
@timleslie timleslie requested a review from emmatown October 4, 2021 21:57
@vercel vercel bot temporarily deployed to Preview October 6, 2021 16:29 Inactive
@vercel vercel bot temporarily deployed to Preview October 7, 2021 05:00 Inactive
@vercel vercel bot temporarily deployed to Preview October 7, 2021 17:02 Inactive
@oplik0
Copy link
Contributor Author

oplik0 commented Oct 7, 2021

Hmm... I'm not sure if it was something with the commits that were rebased in this PR when 9e41771 ran, but it seems that with current code the tests should pass the integration tests: https://github.com/oplik0/keystone/actions/runs/1317933747 (made a separate branch with action changed so it'll run there).

@bladey bladey changed the base branch from master to main October 8, 2021 02:59
@vercel vercel bot temporarily deployed to Preview October 9, 2021 14:36 Inactive
@vercel vercel bot temporarily deployed to Preview October 11, 2021 20:21 Inactive
@vercel vercel bot temporarily deployed to Preview October 13, 2021 20:03 Inactive
@vercel vercel bot temporarily deployed to Preview October 13, 2021 20:15 Inactive
@vercel vercel bot temporarily deployed to Preview October 17, 2021 16:57 Inactive
@vercel vercel bot temporarily deployed to Preview October 25, 2021 00:01 Inactive
@vercel vercel bot temporarily deployed to Preview October 25, 2021 00:05 Inactive
@emmatown emmatown merged commit fb5b21c into keystonejs:main Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document fields are blank when shown as a column in List views
3 participants