Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graphql TS schema extensions #6856

Merged
merged 9 commits into from
Nov 1, 2021
Merged

Graphql TS schema extensions #6856

merged 9 commits into from
Nov 1, 2021

Conversation

emmatown
Copy link
Member

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Oct 31, 2021

🦋 Changeset detected

Latest commit: d947f89

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 15 packages
Name Type
@keystone-next/keystone Minor
@keystone-next/auth Major
@keystone-next/cloudinary Major
@keystone-next/fields-document Major
@keystone-next/session-store-redis Major
@keystone-next/example-auth Patch
@keystone-next/examples-app-basic Patch
@keystone-next/example-ecommerce Patch
keystone-next-app Patch
@keystone-next/example-roles Patch
@keystone-next/example-sandbox Patch
@keystone-next/example-testing Patch
@keystone-next/example-with-auth Patch
@keystone-next/website Patch
@keystone-next/example-document-field Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 31, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/keystonejs/keystone-next-docs/BVt88HXtfhtPNBD1bzhKonGCGRHn
✅ Preview: https://keystone-next-docs-git-graphql-ts-extend-keystonejs.vercel.app

@vercel vercel bot temporarily deployed to Preview October 31, 2021 23:54 Inactive
@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 31, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@vercel vercel bot temporarily deployed to Preview October 31, 2021 23:58 Inactive
@vercel vercel bot temporarily deployed to Preview November 1, 2021 00:19 Inactive
name: gqlNames.RedeemItemMagicAuthTokenResult,
types: [RedeemItemMagicAuthTokenSuccess, RedeemItemMagicAuthTokenFailure],
resolveType(val) {
return 'token' in val
Copy link
Member

@dcousens dcousens Nov 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From @mitchellhamilton in a call, this should never exist as a null, so this change should be OK (and is enforced by Typescript)

@emmatown emmatown merged commit f3e8aac into main Nov 1, 2021
@emmatown emmatown deleted the graphql-ts-extend branch November 1, 2021 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants